From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqutV-0006Ba-Tg for qemu-devel@nongnu.org; Tue, 09 Aug 2011 18:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqutU-0000WX-4G for qemu-devel@nongnu.org; Tue, 09 Aug 2011 18:35:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqutT-0000Vw-TS for qemu-devel@nongnu.org; Tue, 09 Aug 2011 18:35:28 -0400 Message-ID: <4E41B627.3020600@redhat.com> Date: Tue, 09 Aug 2011 16:35:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1280846670-27063-3-git-send-email-kwolf@redhat.com> <201104141110.13280.hahn@univention.de> <4DA6BE7C.3070108@redhat.com> In-Reply-To: <4DA6BE7C.3070108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [BUG] Re: [2/6] loadvm: improve tests before bdrv_snapshot_goto() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: libvir-list@redhat.com, qemu-devel@nongnu.org, Philipp Hahn On 04/14/2011 03:29 AM, Kevin Wolf wrote: > Am 14.04.2011 11:10, schrieb Philipp Hahn: Reviving an old thread... >> Hello, >> >> Am Dienstag 03 August 2010 06:44:26 schrieb Kevin Wolf: >>> From: Miguel Di Ciurcio Filho >>> >>> This patch improves the resilience of the load_vmstate() function, doing >>> further and better ordered tests. >> >> This patch broke restoring not-running VMs using libvirt-0.8.7 with qemu-0.14: >> When the domain is not running while taking a snpshot, the sn.vm_state_size >> == 0: >> >> [...] >> >> Previously the qcow2 image was still reverted to the old state, so on the next >> start of the domain the qcow2 image would be in the state of the snapshot >> >> [...] >> >> Now the qcow2 image is not reverted and when the domain is started, it is NOT >> in the state of the snapshot. >> >> I can't decide if this regression is an Qemu bug or libvirt should be adapted >> to this new behavior. > > Ouch. I wouldn't have expected that libvirt relies on this qemu bug. > When libvirt doesn't use the VM state but boots a fresh VM, it should > call qemu-img snapshot -a for the disks rather than using the loadvm > monitor command. Libvirt should be using 'qemu-img snapshot -a' before reverting to a snapshot made via 'qemu-img snapshot -c'; I'm writing the patch now. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org