From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qr3sZ-0008Qs-Ox for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qr3sU-00075G-6u for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:11:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qr3sT-00075C-TL for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:11:02 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7A8B102029389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Aug 2011 04:11:01 -0400 Received: from rincewind.home.kraxel.org (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7A8AxCW025327 for ; Wed, 10 Aug 2011 04:11:00 -0400 Message-ID: <4E423D13.70106@redhat.com> Date: Wed, 10 Aug 2011 10:10:59 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1312923215-11824-1-git-send-email-alevy@redhat.com> <1312923215-11824-2-git-send-email-alevy@redhat.com> <4E422B2C.6090405@redhat.com> <20110810074329.GE5637@bow.redhat.com> In-Reply-To: <20110810074329.GE5637@bow.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] ui/spice-core: report version in 'info spice' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, >> I think it would also be nice to somehow hint this is the spice > sent a second patch (fixing the above), but didn't do any hinting. I'll send a third. Saw v2. I would just stick a "version" string into the dict instead of the three values for major, minor and micro. >> version qemu was compiled against. The shared library which is >> actually used might be newer. > > I thought of this problem but decided it's better to at least have the compiled > version (getting the linked against version is not hard, but I'd rather > not force to do it at this moment - I guess via dlopen. Which is linux specific - > will need yet another wrapper for that api to compile on windows). The compiled version is perfectly fine, I think it is more useful to have that one as it decides which features qemu is able to use. If we want report the runtime version too (any reason to do this?) I'd just add a spice_server_get_version() function to the library. cheers, Gerd