From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrAZ2-00037F-Ga for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrAYy-0007Ai-Cv for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:19:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48814 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrAYy-0007Aa-2A for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:19:20 -0400 Message-ID: <4E42A175.6050902@suse.de> Date: Wed, 10 Aug 2011 17:19:17 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1312441339-22477-1-git-send-email-david@gibson.dropbear.id.au> <1312441339-22477-4-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1312441339-22477-4-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] pseries: Add real mode debugging hcalls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org On 08/04/2011 09:02 AM, David Gibson wrote: > From: Ben Herrenschmidt > > PAPR systems support several hypercalls intended for use in real mode > debugging tools. These implement reads and writes to arbitrary guest > physical addresses. This is useful for real mode software because it > allows access to IO addresses and memory outside the RMA without going > through the somewhat involved process of setting up the hash page table > and enabling translation. > > We want these so that when we add real IO devices, the SLOF firmware can > boot from them without having to enter virtual mode. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: David Gibson agraf@lychee:/home/agraf/release/qemu> git pw am 108355 ERROR: code indent should never use tabs #40: FILE: hw/spapr_hcall.c:453: +^I^I^I^I target_ulong opcode, target_ulong *args)$ ERROR: code indent should never use tabs #42: FILE: hw/spapr_hcall.c:455: +^Itarget_ulong size = args[0];$ ERROR: code indent should never use tabs #43: FILE: hw/spapr_hcall.c:456: +^Itarget_ulong addr = args[1];$ ERROR: code indent should never use tabs #45: FILE: hw/spapr_hcall.c:458: +^Iswitch(size) {$ ERROR: space required before the open parenthesis '(' #45: FILE: hw/spapr_hcall.c:458: + switch(size) { ERROR: code indent should never use tabs #46: FILE: hw/spapr_hcall.c:459: +^Icase 1:$ ERROR: code indent should never use tabs #47: FILE: hw/spapr_hcall.c:460: +^I^Iargs[0] = ldub_phys(addr);$ ERROR: code indent should never use tabs #48: FILE: hw/spapr_hcall.c:461: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #49: FILE: hw/spapr_hcall.c:462: +^Icase 2:$ ERROR: code indent should never use tabs #50: FILE: hw/spapr_hcall.c:463: +^I^Iargs[0] = lduw_phys(addr);$ ERROR: code indent should never use tabs #51: FILE: hw/spapr_hcall.c:464: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #52: FILE: hw/spapr_hcall.c:465: +^Icase 4:$ ERROR: code indent should never use tabs #53: FILE: hw/spapr_hcall.c:466: +^I^Iargs[0] = ldl_phys(addr);$ ERROR: code indent should never use tabs #54: FILE: hw/spapr_hcall.c:467: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #55: FILE: hw/spapr_hcall.c:468: +^Icase 8:$ ERROR: code indent should never use tabs #56: FILE: hw/spapr_hcall.c:469: +^I^Iargs[0] = ldq_phys(addr);$ ERROR: code indent should never use tabs #57: FILE: hw/spapr_hcall.c:470: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #58: FILE: hw/spapr_hcall.c:471: +^I}$ ERROR: code indent should never use tabs #59: FILE: hw/spapr_hcall.c:472: +^Ireturn H_PARAMETER;$ ERROR: code indent should never use tabs #63: FILE: hw/spapr_hcall.c:476: +^I^I^I^I target_ulong opcode, target_ulong *args)$ ERROR: code indent should never use tabs #65: FILE: hw/spapr_hcall.c:478: +^Itarget_ulong size = args[0];$ ERROR: code indent should never use tabs #66: FILE: hw/spapr_hcall.c:479: +^Itarget_ulong addr = args[1];$ ERROR: code indent should never use tabs #67: FILE: hw/spapr_hcall.c:480: +^Itarget_ulong val = args[2];$ ERROR: code indent should never use tabs #69: FILE: hw/spapr_hcall.c:482: +^Iswitch(size) {$ ERROR: space required before the open parenthesis '(' #69: FILE: hw/spapr_hcall.c:482: + switch(size) { ERROR: code indent should never use tabs #70: FILE: hw/spapr_hcall.c:483: +^Icase 1:$ ERROR: code indent should never use tabs #71: FILE: hw/spapr_hcall.c:484: +^I^Istb_phys(addr, val);$ ERROR: code indent should never use tabs #72: FILE: hw/spapr_hcall.c:485: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #73: FILE: hw/spapr_hcall.c:486: +^Icase 2:$ ERROR: code indent should never use tabs #74: FILE: hw/spapr_hcall.c:487: +^I^Istw_phys(addr, val);$ ERROR: code indent should never use tabs #75: FILE: hw/spapr_hcall.c:488: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #76: FILE: hw/spapr_hcall.c:489: +^Icase 4:$ ERROR: code indent should never use tabs #77: FILE: hw/spapr_hcall.c:490: +^I^Istl_phys(addr, val);$ ERROR: code indent should never use tabs #78: FILE: hw/spapr_hcall.c:491: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #79: FILE: hw/spapr_hcall.c:492: +^Icase 8:$ ERROR: trailing whitespace #80: FILE: hw/spapr_hcall.c:493: +^I^Istq_phys(addr, val);^I$ ERROR: code indent should never use tabs #80: FILE: hw/spapr_hcall.c:493: +^I^Istq_phys(addr, val);^I$ ERROR: code indent should never use tabs #81: FILE: hw/spapr_hcall.c:494: +^I^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #82: FILE: hw/spapr_hcall.c:495: +^I}$ ERROR: code indent should never use tabs #83: FILE: hw/spapr_hcall.c:496: +^Ireturn H_PARAMETER;$ ERROR: code indent should never use tabs #87: FILE: hw/spapr_hcall.c:500: +^I^I^I^I target_ulong opcode, target_ulong *args)$ ERROR: code indent should never use tabs #89: FILE: hw/spapr_hcall.c:502: +^I/* Nothing to do on emulation, KVM will trap this in the kernel */$ ERROR: code indent should never use tabs #90: FILE: hw/spapr_hcall.c:503: +^Ireturn H_SUCCESS;$ ERROR: code indent should never use tabs #94: FILE: hw/spapr_hcall.c:507: +^I^I^I^I target_ulong opcode, target_ulong *args)$ ERROR: code indent should never use tabs #96: FILE: hw/spapr_hcall.c:509: +^I/* Nothing to do on emulation, KVM will trap this in the kernel */$ ERROR: code indent should never use tabs #97: FILE: hw/spapr_hcall.c:510: +^Ireturn H_SUCCESS;$ ERROR: trailing whitespace #118: FILE: hw/spapr_hcall.c:588: + $ total: 47 errors, 0 warnings, 86 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.