From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QrAie-0008Ki-CT
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:29:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QrAiZ-000146-UK
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:29:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QrAiZ-000140-KQ
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 11:29:15 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7AFTEhV011141
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 10 Aug 2011 11:29:14 -0400
Message-ID: <4E42A3C0.7070201@redhat.com>
Date: Wed, 10 Aug 2011 17:29:04 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1312989789-976-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1312989789-976-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5] ui/spice-core: report compiled-version
	in info spice/query-spice
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

> +    char version_string[20]; // 12 = |255.255.255\0| is the max

checkpatch reports:

ERROR: do not use C99 // comments
#19: FILE: ui/spice-core.c:393:
+    char version_string[20]; // 12 = |255.255.255\0| is the max

cheers,
   Gerd