From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrBkt-000889-M4 for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrBko-0000fq-Rl for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:35:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrBko-0000fl-AV for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:35:38 -0400 Message-ID: <4E42B356.9090809@redhat.com> Date: Wed, 10 Aug 2011 19:35:34 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312823229-12822-1-git-send-email-avi@redhat.com> <1312823229-12822-22-git-send-email-avi@redhat.com> <4E42B0A5.1010005@twiddle.net> <4E42B123.8070605@twiddle.net> In-Reply-To: <4E42B123.8070605@twiddle.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/10/2011 07:26 PM, Richard Henderson wrote: > On 08/10/2011 09:24 AM, Richard Henderson wrote: > > Of course, as far as I can see, this variable is only used by > > the VGA devices. Surely we can arrange to pass down some address > > space during setup of the VGA? > > ... Which seems to be what you've done in patch 23. > > So what's the point of this patch? > > Okay, so I'm learning a lot and also applying that learning... a good thing except that I've forgotten all about it. Had a similar case with omap_gpmc. Again, there's so much work here that the quality is bound to be less than perfect. The plan is to have a pretty good end result though (fully hierarchical - no globals). -- error compiling committee.c: too many arguments to function