From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrBnv-0001D0-Ld for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:38:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrBno-0001Pm-RI for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:38:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrBno-0001Pa-HD for qemu-devel@nongnu.org; Wed, 10 Aug 2011 12:38:44 -0400 Message-ID: <4E42B40F.2040109@redhat.com> Date: Wed, 10 Aug 2011 19:38:39 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1312823229-12822-1-git-send-email-avi@redhat.com> <1312823229-12822-22-git-send-email-avi@redhat.com> <4E42B0A5.1010005@twiddle.net> <4E42B123.8070605@twiddle.net> <4E42B356.9090809@redhat.com> In-Reply-To: <4E42B356.9090809@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/10/2011 07:35 PM, Avi Kivity wrote: > On 08/10/2011 07:26 PM, Richard Henderson wrote: >> On 08/10/2011 09:24 AM, Richard Henderson wrote: >> > Of course, as far as I can see, this variable is only used by >> > the VGA devices. Surely we can arrange to pass down some address >> > space during setup of the VGA? >> >> ... Which seems to be what you've done in patch 23. >> >> So what's the point of this patch? >> >> > > Okay, so I'm learning a lot and also applying that learning... a good > thing except that I've forgotten all about it. Had a similar case > with omap_gpmc. > Well, actually reading patch 23, this one doesn't make much sense. I'd like to let it in though. If I spend time polishing patchsets I'll never get rid of ram_addr_t. The plan is: - convert devices - clean up bus APIs If I do all of the at once, it will end up in tears. -- error compiling committee.c: too many arguments to function