From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrObQ-0005u7-CK
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:18:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrObP-0007yW-DY
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:18:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrObP-0007yS-3B
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:18:47 -0400
Message-ID: <4E437442.5090808@redhat.com>
Date: Thu, 11 Aug 2011 09:18:42 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1313015300-23920-1-git-send-email-rth@twiddle.net>
	<1313015300-23920-4-git-send-email-rth@twiddle.net>
In-Reply-To: <1313015300-23920-4-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/11] isa: add isa_register_ioport()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 08/11/2011 01:28 AM, Richard Henderson wrote:
> To replace isa_init_ioport and isa_init_ioport_range
> as the ISA devices are converted to the memory api.
>
>
> +void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start)
> +{
> +    memory_region_add_subregion(isabus->address_space_io, start, io);
> +    if (dev != NULL) {
> +        assert(dev->nio<  ARRAY_SIZE(dev->io));
> +        dev->io[dev->nio++] = io;
> +        isa_init_ioport_range(dev, start, io->size);
> +    }
> +}

memory_region_size(io);

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.