From: Avi Kivity <avi@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.
Date: Thu, 11 Aug 2011 09:27:53 +0300 [thread overview]
Message-ID: <4E437669.2000507@redhat.com> (raw)
In-Reply-To: <4E437539.2020207@redhat.com>
On 08/11/2011 09:22 AM, Avi Kivity wrote:
> On 08/11/2011 01:28 AM, Richard Henderson wrote:
>> }
>> };
>>
>> +static const MemoryRegionOps cs_ioport_ops = {
>> + .read = cs_read,
>> + .write = cs_write,
>> + .impl = {
>> + .min_access_size = 1,
>> + .max_access_size = 1,
>> + }
>> +};
>
> Should be .valid, not .impl.
>
> .impl means the implementation only supports this access size; emulate
> other sizes by using a supported size (e.g. crack a 4-byte access into
> 4 1-byte accesses). .valid means what the device actually supports;
> if the guest uses another size something bus-defined happens.
Oh, the standard qemu implementation auto-cracks, so .impl is correct.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-08-11 6:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 22:28 [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 01/11] pci: add pci_address_space_io() Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 02/11] isa: Pass i/o address space to isa_bus_new Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 03/11] isa: add isa_register_ioport() Richard Henderson
2011-08-11 6:18 ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 04/11] pc: Re-order pc_init1 to initialize the ISA bus before ISA devices Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion Richard Henderson
2011-08-11 6:22 ` Avi Kivity
2011-08-11 6:27 ` Avi Kivity [this message]
2011-08-10 22:28 ` [Qemu-devel] [PATCH 06/11] i8254: " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 07/11] i8259: " Richard Henderson
2011-08-28 15:25 ` Avi Kivity
2011-08-10 22:28 ` [Qemu-devel] [PATCH 08/11] pckbd: " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 09/11] serial: Convert serial_isa_initfn " Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 10/11] memory: Fix old_portio vs non-zero offset Richard Henderson
2011-08-10 22:28 ` [Qemu-devel] [PATCH 11/11] fdc: Convert isabus_fdc_init1 to MemoryRegion Richard Henderson
2011-08-11 7:48 ` [Qemu-devel] [PATCH 00/11] Memory API conversion for ISA Avi Kivity
2011-08-11 8:05 ` Edgar E. Iglesias
2011-08-11 8:20 ` Avi Kivity
2011-08-11 10:24 ` Edgar E. Iglesias
2011-08-11 11:19 ` Avi Kivity
2011-08-11 14:58 ` Richard Henderson
2011-08-11 15:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E437669.2000507@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).