From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrOkM-0008C6-G4 for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:28:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrOkH-0000Wl-Rk for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:28:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrOkH-0000Wg-JQ for qemu-devel@nongnu.org; Thu, 11 Aug 2011 02:27:57 -0400 Message-ID: <4E437669.2000507@redhat.com> Date: Thu, 11 Aug 2011 09:27:53 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1313015300-23920-1-git-send-email-rth@twiddle.net> <1313015300-23920-6-git-send-email-rth@twiddle.net> <4E437539.2020207@redhat.com> In-Reply-To: <4E437539.2020207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 08/11/2011 09:22 AM, Avi Kivity wrote: > On 08/11/2011 01:28 AM, Richard Henderson wrote: >> } >> }; >> >> +static const MemoryRegionOps cs_ioport_ops = { >> + .read = cs_read, >> + .write = cs_write, >> + .impl = { >> + .min_access_size = 1, >> + .max_access_size = 1, >> + } >> +}; > > Should be .valid, not .impl. > > .impl means the implementation only supports this access size; emulate > other sizes by using a supported size (e.g. crack a 4-byte access into > 4 1-byte accesses). .valid means what the device actually supports; > if the guest uses another size something bus-defined happens. Oh, the standard qemu implementation auto-cracks, so .impl is correct. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.