From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrXAk-0004Ol-2q for qemu-devel@nongnu.org; Thu, 11 Aug 2011 11:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrXAj-0001i1-0B for qemu-devel@nongnu.org; Thu, 11 Aug 2011 11:27:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrXAi-0001hw-O2 for qemu-devel@nongnu.org; Thu, 11 Aug 2011 11:27:48 -0400 Message-ID: <4E43F4EF.7070907@redhat.com> Date: Thu, 11 Aug 2011 17:27:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1312478089-806-1-git-send-email-pbonzini@redhat.com> <1312478089-806-6-git-send-email-pbonzini@redhat.com> <20110811075836.GB29542@stefanha-thinkpad.localdomain> <4E43C6CE.9070008@redhat.com> <4E43E619.601@redhat.com> <4E43E928.8060208@redhat.com> <4E43EFA9.4010501@redhat.com> <4E43F167.2030902@redhat.com> In-Reply-To: <4E43F167.2030902@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On 08/11/2011 05:12 PM, Kevin Wolf wrote: >> > Another possibility is always completing DMA in a bottom half. This >> > ensures that the callback can access the AIOCB, but it exposes an >> > implementation detail to the caller, so I don't like it. > > At least in the block layer, AIO callbacks may never be called before > the submission function has returned. I think this makes the DMA helpers > provide the same behaviour. > > But I'm not sure if the definition of the AIOCB struct isn't private to > the block layer. Yes, it is; I would add a getter that is specific to the DMAAIOCB. Paolo