From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59813)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrZYr-0000bV-PV
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:00:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrZYn-0007xK-4R
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:00:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QrZYm-0007xC-Pq
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:00:49 -0400
Message-ID: <4E4402AC.3080505@redhat.com>
Date: Thu, 11 Aug 2011 19:26:20 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1312823229-12822-1-git-send-email-avi@redhat.com>
	<1312823229-12822-19-git-send-email-avi@redhat.com>
	<CAFEAcA-v2ALCw52Szh9SUB+-n072t0+zKeO3nF_wxB5_TFjryQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-v2ALCw52Szh9SUB+-n072t0+zKeO3nF_wxB5_TFjryQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 08/11/2011 07:20 PM, Peter Maydell wrote:
> On 8 August 2011 18:07, Avi Kivity<avi@redhat.com>  wrote:
> >  -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr)
> >  +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr,
> >  +                                    unsigned size)
> >    {
> >       uint32_t val;
> >  -    val = pci_data_read(opaque, vpb_pci_config_addr (addr), 1);
> >  -    return val;
> >  +    val = pci_data_read(opaque, vpb_pci_config_addr(addr), size);
> >  +    return size;
> >    }
>
> This should be 'return val', not 'return size', I think...

Wow, how did that happen?

> (otherwise PCI is broken on versatilepb; tested with your memory-region
> branch rather than with this particular patch.)
>

Updated patch to follow, thanks for the report.

-- 
error compiling committee.c: too many arguments to function