qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header
Date: Fri, 12 Aug 2011 08:45:47 -0500	[thread overview]
Message-ID: <4E452E8B.1090604@us.ibm.com> (raw)
In-Reply-To: <1312999851-28390-1-git-send-email-mdroth@linux.vnet.ibm.com>

On 08/10/2011 01:10 PM, Michael Roth wrote:
> Fixes a build issue on RHEL5, and potentially other distros, where gcc
> will generate an error due to us not writing a trailing "\n" when
> generating *qmp-commands.h
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>

Applied to master.  Thanks.

Regards,

Anthony Liguori

> ---
>   scripts/qapi-commands.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
> index 9ad4c54..bf61740 100644
> --- a/scripts/qapi-commands.py
> +++ b/scripts/qapi-commands.py
> @@ -375,7 +375,7 @@ if dispatch_type == "sync":
>           ret = gen_marshal_input(cmd['command'], arglist, ret_type) + "\n"
>           fdef.write(ret)
>
> -    fdecl.write("\n#endif");
> +    fdecl.write("\n#endif\n");
>       ret = gen_registry(commands)
>       fdef.write(ret)
>

      reply	other threads:[~2011-08-12 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 18:10 [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to missing newline in generated header Michael Roth
2011-08-12 13:45 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E452E8B.1090604@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).