From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrsE7-0006eE-P3 for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrsE6-0002tf-QN for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:56:43 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:45155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrsE6-0002tb-Nv for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:56:42 -0400 Received: by gyd12 with SMTP id 12so2319145gyd.4 for ; Fri, 12 Aug 2011 06:56:42 -0700 (PDT) Message-ID: <4E453117.6040600@codemonkey.ws> Date: Fri, 12 Aug 2011 08:56:39 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1313065515-3815-1-git-send-email-hdegoede@redhat.com> <1313065515-3815-3-git-send-email-hdegoede@redhat.com> In-Reply-To: <1313065515-3815-3-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/5] usb-redir: Call qemu_chr_guest_open/close List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: Gerd Hoffmann , qemu-devel@nongnu.org On 08/11/2011 07:25 AM, Hans de Goede wrote: > To let the chardev now we're ready start receiving data. This is necessary > with the spicevmc chardev to get it registered with the spice-server. > > Signed-off-by: Hans de Goede > --- > usb-redir.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/usb-redir.c b/usb-redir.c > index 6932beb..9ce2c8b 100644 > --- a/usb-redir.c > +++ b/usb-redir.c > @@ -839,6 +839,8 @@ static int usbredir_initfn(USBDevice *udev) > /* We'll do the attach once we receive the speed from the usb-host */ > udev->auto_attach = 0; > > + /* Let the other side know we are ready */ > + qemu_chr_guest_open(dev->cs); > qemu_chr_add_handlers(dev->cs,&usbredir_chr_handlers, dev); Not sure what tree this is against, but it's not qemu.git. Regards, Anthony Liguori > > return 0; > @@ -861,6 +863,7 @@ static void usbredir_handle_destroy(USBDevice *udev) > { > USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev); > > + qemu_chr_guest_close(dev->cs); > qemu_chr_close(dev->cs); > /* Note must be done after qemu_chr_close, as that causes a close event */ > qemu_bh_delete(dev->open_close_bh);