From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrsEz-0007Sw-DG for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrsEy-0003JV-5w for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:57:37 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:43981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrsEy-0003JN-0V for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:57:36 -0400 Received: by yxt3 with SMTP id 3so2295329yxt.4 for ; Fri, 12 Aug 2011 06:57:35 -0700 (PDT) Message-ID: <4E45314D.2020004@codemonkey.ws> Date: Fri, 12 Aug 2011 08:57:33 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1313065515-3815-1-git-send-email-hdegoede@redhat.com> In-Reply-To: <1313065515-3815-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: Gerd Hoffmann , qemu-devel@nongnu.org On 08/11/2011 07:25 AM, Hans de Goede wrote: > Make qemu_chr_event public so that it can be used by chardev code > which lives outside of qemu-char.c Normally, qemu_chr_generic_open() would be used to do this. Of course, there is no generic_close(). Are you sure you don't need the BH indirection? Regards, Anthony Liguori > > Signed-off-by: Hans de Goede > --- > qemu-char.c | 2 +- > qemu-char.h | 1 + > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 8d39500..5d5a6d5 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -119,7 +119,7 @@ static void char_write_unblocked(void *opaque) > chr->chr_write_unblocked(chr->handler_opaque); > } > > -static void qemu_chr_event(CharDriverState *s, int event) > +void qemu_chr_event(CharDriverState *s, int event) > { > /* Keep track if the char device is open */ > switch (event) { > diff --git a/qemu-char.h b/qemu-char.h > index 68e7b5b..77ad62d 100644 > --- a/qemu-char.h > +++ b/qemu-char.h > @@ -107,6 +107,7 @@ int qemu_chr_ioctl(CharDriverState *s, int cmd, void *arg); > void qemu_chr_generic_open(CharDriverState *s); > int qemu_chr_can_read(CharDriverState *s); > void qemu_chr_read(CharDriverState *s, uint8_t *buf, int len); > +void qemu_chr_event(CharDriverState *s, int event); > int qemu_chr_get_msgfd(CharDriverState *s); > void qemu_chr_accept_input(CharDriverState *s); > int qemu_chr_add_client(CharDriverState *s, int fd);