From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qrsub-0000XA-Sh for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrsuZ-0002t2-K7 for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:40:37 -0400 Received: from mailrelay.tu-graz.ac.at ([129.27.2.202]:8400 helo=mailrelay.tugraz.at) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrsuZ-0002oG-2N for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:40:35 -0400 Message-ID: <4E453B29.7060308@iaik.tugraz.at> Date: Fri, 12 Aug 2011 16:39:37 +0200 From: Andreas Niederl MIME-Version: 1.0 References: <20110810165122.639452836@linux.vnet.ibm.com> <20110810165136.716893022@linux.vnet.ibm.com> In-Reply-To: <20110810165136.716893022@linux.vnet.ibm.com> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms020805030508090307000604" Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH V6 1/9] Add an implementation of a TPM TIS driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: seabios@seabios.org, qemu-devel@nongnu.org This is a cryptographically signed message in MIME format. --------------ms020805030508090307000604 Content-Type: multipart/mixed; boundary="------------020107030408040804080700" This is a multi-part message in MIME format. --------------020107030408040804080700 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi, compiling SeaBios with your patch produces the following error for me with gcc-4.4.5: src/tpm_drivers.c: In function =91tis_init=92: src/tpm_drivers.c:43: error: =91tpm_drivers=92 undeclared (first use in t= his function) The attached patch should fix this. Regards, Andreas --------------020107030408040804080700 Content-Type: text/plain; name="tcgbios_tpm_drivers_decl.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="tcgbios_tpm_drivers_decl.diff" commit 065be9bee0a0f13cdcc266161c273bd3155e6eb8 (HEAD, t/libtpms-V6) Author: Andreas Niederl Date: Fri Aug 12 15:47:27 2011 +0200 Move tpm_drivers[] declaration to tpm_drivers.h diff --git a/src/tcgbios.c b/src/tcgbios.c index 111fe8a..ae52520 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -86,8 +86,6 @@ static tcpa_state_t tcpa_state =3D { .tpm_driver_to_use =3D TPM_INVALID_DRIVER, }; =20 -extern struct tpm_driver tpm_drivers[]; - typedef struct { u8 op; } tpm_bios_cfg_t; diff --git a/src/tpm_drivers.h b/src/tpm_drivers.h index 6b593db..27a040f 100644 --- a/src/tpm_drivers.h +++ b/src/tpm_drivers.h @@ -28,6 +28,8 @@ struct tpm_driver { u32 sha1threshold; }; =20 +extern struct tpm_driver tpm_drivers[]; + #define TIS_DRIVER_IDX 0 #define TPM_NUM_DRIVERS 1 =20 --------------020107030408040804080700-- --------------ms020805030508090307000604 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIVNDCC BJAwggN4oAMCAQICAQEwDQYJKoZIhvcNAQEFBQAwQzEQMA4GA1UEChMHRXVyb1BLSTEVMBMG A1UECxMMRXVyb1BLSSByb290MRgwFgYDVQQDEw9FdXJvUEtJIHJvb3QgQ0EwHhcNMTAxMjE4 MTM0NTQ0WhcNMjAxMjMxMjM1OTU5WjBsMQswCQYDVQQGEwJBVDEQMA4GA1UEChMHRXVyb1BL STEYMBYGA1UECxMPRXVyb1BLSSBBdXN0cmlhMTEwLwYDVQQDEyhFdXJvUEtJIEF1c3RyaWFu IENlcnRpZmljYXRpb24gQXV0aG9yaXR5MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAtYWVDVGtJcr+bbQJ+2UcnyOMzvgXNn5k4paQCAXyf9sqn3Rygnf69nM3gpnvOUtvfLoQ qw7SmV0KesGacRrGa2cOZ/Jq11Vcuh1ExU8imqc/+Ft70tH93ypY6VIqCfZQVMEMgEQ3Dcwj +t/iL/Tqqx4G+EKEn5g5a1+Spmhg2hIKDWG5GMBQ59G/NSNeo/JlwwxArUDP2bMc45B2c9ZL N45f6vRFtTsXQ+srYLHj1835n1o3cLAfCso1yFDaSzAczyt6k48HrxlEI3wgidYQturdhvQV j3B1FMNP+IAi/4xgy1AJjFqNc9R/4MpPVa07FLj9x2e3xJTKX6piKsq+vQIDAQABo4IBZDCC AWAwDwYDVR0TAQH/BAUwAwEB/zAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0OBBYEFHQp2FGvwjyY p9f/MY9A91DoBwHoMB8GA1UdIwQYMBaAFPBxHCgzWLfFxrXDv1F1qFD0nNI0MEkGA1UdIARC MEAwPgYKKwYBBAGpBwEBAjAwMC4GCCsGAQUFBwIBFiJodHRwOi8vd3d3LmV1cm9wa2kub3Jn L2NhL2Nwcy8xLjIvMHEGCCsGAQUFBwEBBGUwYzAjBggrBgEFBQcwAYYXaHR0cDovL29jc3Au ZXVyb3BraS5vcmcwPAYIKwYBBQUHMAKGMGh0dHA6Ly93d3cuZXVyb3BraS5vcmcvY2EvY2Vy dHMvZXVyb3BraV9yb290LmNlcjA/BgNVHR8EODA2MDSgMqAwhi5odHRwOi8vd3d3LmV1cm9w a2kub3JnL2NhL2NybC9ldXJvcGtpX3Jvb3QuY3JsMA0GCSqGSIb3DQEBBQUAA4IBAQBNVfMP eyPHqOTovqVrPDJ7q9KFNZ5tV2VEOsLXacxN1qNDGoMXN9QD0GkNIZfu/UzoW5eV0/IB3mEd WuVfQ9vCx8A1gJv/omdz9lC7ASOudDBQC3a6/tkv7te3i//dLcYvqI/lSalmI9TV/6ALYEe1 I1fTI7V8A1vi9PN+cXM6sTwumavMTUh6tkLIyrNS6AeRjf74W2owfEtp8vF9tmvItrl1/QCh FwwFjye93KCaQStz0sga2Ze489oBvi3lwg+Miv3/eWpu/UbZEbGqSF+z9LzPvTowvUEEoY9J Dsl/6I9I13/IMtm6T3SjdI0+6X1m1v/tqO1nbKZAaH7mdtjeMIIFUTCCBDmgAwIBAgIHAMRD e77gVzANBgkqhkiG9w0BAQUFADBsMQswCQYDVQQGEwJBVDEQMA4GA1UEChMHRXVyb1BLSTEY MBYGA1UECxMPRXVyb1BLSSBBdXN0cmlhMTEwLwYDVQQDEyhFdXJvUEtJIEF1c3RyaWFuIENl cnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTEwMTIyNzEzMDQxNloXDTIwMTIyNzEzMDQxNlow gb0xLTArBgNVBAMTJEV1cm9QS0kgSUFJSyBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEmMCQG A1UEChMdR3JheiBVbml2ZXJzaXR5IG9mIFRlY2hub2xvZ3kxSDBGBgNVBAsTP0luc3RpdHV0 ZSBmb3IgQXBwbGllZCBJbmZvcm1hdGlvbiBQcm9jZXNzaW5nIGFuZCBDb21tdW5pY2F0aW9u czENMAsGA1UEBxMER3JhejELMAkGA1UEBhMCQVQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQCVatVA1TczvPSG2IZoIPtEBXNgZSdUx58syuOEoZs9HOc0MocB2ko3jIDfB9YI P7bLEag1yjrlO8GxfkBCiTQvnfNDEIMvetuwJmHSgaTxJ3PRlOWDJMi/IbNeX1yq2sOYyszp bK5/jm6JAl/XbYNmNuiPxx2PR3iVZBL4v38sF7o0x/ale5P7RmW4KXq36Mpc/KaAW4cMrDUA GNqcc9EIwkTAx1moGt8u7v/CTgWIilXbhB1BBBjp+Cy9ukBX+HnwimWlAcKFDTqmwFmgJA+Q lCEQYHs0o2ylWF+41N8MivLlYqvqQlpOFqWStBpKr8lxkcjpFRzFry2ORWlK16+bAgMBAAGj ggGkMIIBoDAOBgNVHQ8BAf8EBAMCAcYwDwYDVR0TAQH/BAUwAwEB/zAdBgNVHQ4EFgQUOXTH 3cjx+wpwPQ7KfUUCrKGb154wVgYDVR0gBE8wTTBLBgwrBgEEAZUSAQIBAQEwOzA5BggrBgEF BQcCARYtaHR0cDovL2V1cm9wa2kuaWFpay5hdC9jYS9ldXJvcGtpLWF0L2Nwcy8xLjEvMEgG A1UdHwRBMD8wPaA7oDmGN2h0dHA6Ly9jYS5pYWlrLnR1Z3Jhei5hdC9jYXBzby9jcmxzL0V1 cm9QS0lBdXN0cmlhbi5jcmwwgZoGCCsGAQUFBwEBBIGNMIGKMEIGCCsGAQUFBzABhjZodHRw Oi8vY2EuaWFpay50dWdyYXouYXQvY2Fwc28vT0NTUD9jYT1FdXJvUEtJQXVzdHJpYW4wRAYI KwYBBQUHMAKGOGh0dHA6Ly9jYS5pYWlrLnR1Z3Jhei5hdC9jYXBzby9jZXJ0cy9FdXJvUEtJ QXVzdHJpYW4uY2VyMB8GA1UdIwQYMBaAFHQp2FGvwjyYp9f/MY9A91DoBwHoMA0GCSqGSIb3 DQEBBQUAA4IBAQACSfw9hGncZLQqEn2U3e0XoKHOBSxE7XxcmQ2Kdd96C/Z0nSkp3Pc0g1Fp o3uSoQssBd3R3pvDPasf5eGjQkLKnPlR2PL7YWXVNjCckJBzU6S77Uv3saaXJUXkfgKRGkoK /Kv+ewx0vJ6ZdAmGxhgcj8k/yseJQJm7CV+EmjsYgWYO74ln427M+UxoKlyC5bQJT9M+xCgc rnSMUZdAZIYws/bXum4yyluJvC7nfFxilO9PsVph0kWUlewyg1ESKf9uF9GSp0Lrp/o3zbdG COFCgYRAKuMkDIJ4dYYHm+VDvnyEHKyNW5vij9R53fcL8jFd8bwAWaLUeG7j6L1hVQ1xMIIF gDCCBGigAwIBAgIHA0DrJxk2fDANBgkqhkiG9w0BAQUFADCBvTEtMCsGA1UEAxMkRXVyb1BL SSBJQUlLIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MSYwJAYDVQQKEx1HcmF6IFVuaXZlcnNp dHkgb2YgVGVjaG5vbG9neTFIMEYGA1UECxM/SW5zdGl0dXRlIGZvciBBcHBsaWVkIEluZm9y bWF0aW9uIFByb2Nlc3NpbmcgYW5kIENvbW11bmljYXRpb25zMQ0wCwYDVQQHEwRHcmF6MQsw CQYDVQQGEwJBVDAeFw0wODAyMjgxNTQ0MTdaFw0xMzAyMjgxNTQ0MTdaMIGsMRwwGgYDVQQD ExNFdXJvUEtJIElBSUsgU2lnIENBMSYwJAYDVQQKEx1HcmF6IFVuaXZlcnNpdHkgb2YgVGVj aG5vbG9neTFIMEYGA1UECxM/SW5zdGl0dXRlIGZvciBBcHBsaWVkIEluZm9ybWF0aW9uIFBy b2Nlc3NpbmcgYW5kIENvbW11bmljYXRpb25zMQ0wCwYDVQQHEwRHcmF6MQswCQYDVQQGEwJB VDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALBs2U2/lTXnomXhgNULWkAXS507 A6UtmsbrAIXXK7XIWgyjbKiYASrdej0LPKGuFtxbZ+A/e1cSV8yrCWsB+4s8jZwL+xbWeXIG caKarv0npeXSqX0UZl7DM5mVID+FwG1T73qjmIGvE6i5qDnNEv0siGeit7m0AH3dF2uckq6e KuozAvchlJOQk27PqaPRFCS5APiCNBrB9AUShjXMHso1wC1raxlsGDc/yneC2Z4OOBZLkswP IMu0qUwVfGVR7u3WFLEP3cPXw8lWb1Ka8GzGLBivt4PRz+wyibDfWx/i/SnhTzfEuB4y1PFj vsFQ3o3am2zHpqvy1WPfUsxRLQ0CAwEAAaOCAZIwggGOMA4GA1UdDwEB/wQEAwIBxjAPBgNV HRMBAf8EBTADAQH/MB0GA1UdDgQWBBSu7lUGF3pTERMYq6TOHHEJGoMU8zBQBgNVHSAESTBH MEUGDCsGAQQBlRIBAgMBATA1MDMGCCsGAQUFBwIBFidodHRwOi8vZXVyb3BraS5pYWlrLmF0 L2NhL2lhaWsvY3BzLzEuMy8wRAYDVR0fBD0wOzA5oDegNYYzaHR0cDovL2NhLmlhaWsudHVn cmF6LmF0L2NhcHNvL2NybHMvRXVyb1BLSUlBSUsuY3JsMIGSBggrBgEFBQcBAQSBhTCBgjA+ BggrBgEFBQcwAYYyaHR0cDovL2NhLmlhaWsudHVncmF6LmF0L2NhcHNvL09DU1A/Y2E9RXVy b1BLSUlBSUswQAYIKwYBBQUHMAKGNGh0dHA6Ly9jYS5pYWlrLnR1Z3Jhei5hdC9jYXBzby9j ZXJ0cy9FdXJvUEtJSUFJSy5jZXIwHwYDVR0jBBgwFoAUOXTH3cjx+wpwPQ7KfUUCrKGb154w DQYJKoZIhvcNAQEFBQADggEBAAgys3wJ2CixcC8KuuO3a9k8u0nT0+PafLR9wMQMWsz7xDTL NxiTJKnLvdFw86D+CH+nXxRweo/KDVYT56q5rfKs45I6mZDV+z/wecNX3odWMuY5a6j0g/RR 4Qz/wokfeUzff5Yi6Hh1P9ce0u3/EHAHancJI3FxoZpLU5qNWZNo+fI6nluOBmdJCWZgCR9i jucmFubnu4EbWlyhiH2e0H2taU6zWvW/83yqbEO0BhDKVWWVtWvlF/ptBZQEJzAD1q5XJobP NQ/IANfs5ZcfuC1+Pm6FEG0cMVnDCGlRoA57oTIFaODWQPr4gxMy11/MYe9VufBih5AU1z6V 4IwJ5SYwggXDMIIEq6ADAgECAgcA0sFq7kLzMA0GCSqGSIb3DQEBBQUAMIGsMRwwGgYDVQQD ExNFdXJvUEtJIElBSUsgU2lnIENBMSYwJAYDVQQKEx1HcmF6IFVuaXZlcnNpdHkgb2YgVGVj aG5vbG9neTFIMEYGA1UECxM/SW5zdGl0dXRlIGZvciBBcHBsaWVkIEluZm9ybWF0aW9uIFBy b2Nlc3NpbmcgYW5kIENvbW11bmljYXRpb25zMQ0wCwYDVQQHEwRHcmF6MQswCQYDVQQGEwJB VDAeFw0wODExMDYxNTUwMzVaFw0xMTExMDYxNTUwMzVaMIHMMRAwDgYDVQQqEwdBbmRyZWFz MRAwDgYDVQQEEwdOaWVkZXJsMRgwFgYDVQQDEw9BbmRyZWFzIE5pZWRlcmwxJjAkBgNVBAoT HUdyYXogVW5pdmVyc2l0eSBvZiBUZWNobm9sb2d5MUgwRgYDVQQLEz9JbnN0aXR1dGUgZm9y IEFwcGxpZWQgSW5mb3JtYXRpb24gUHJvY2Vzc2luZyBhbmQgQ29tbXVuaWNhdGlvbnMxDTAL BgNVBAcTBEdyYXoxCzAJBgNVBAYTAkFUMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAqa5inSL4YibfWVAYwkrwEMrNuMp6N28/PzjWZReTmfsRZ2kxePbdI9DfTbhn+3arBcba Wypn0S2BXQYXVlp8o2RlU5PtBKHrKwXkwBCskE78EyXL9tGwQd62gsjyCbum39zuhBEu2Slm oyRwwxEVF8s89Uq6zeU7U7/F549TayqlFsPH9eAtuH8LmZhW2DEKVbnH5lTVRzgXwSV5UJEd 6xuPCodk82g0YZyEi7Kr+6rhIX4FcXTis6cFeuufKign5guXWaRu97MwGzxy6g7YPRjJ37pl KC0RjWEbRoLcV0IGQ3fQd8wkQdgd9+zY5xZXTOCIXuTxfOiW5McT8hBA9wIDAQABo4IBxjCC AcIwDgYDVR0PAQH/BAQDAgbAMAwGA1UdEwEB/wQCMAAwHQYDVR0OBBYEFBL99AyoY0HlzxGr 9Y9pZyBW23SPMFAGA1UdIARJMEcwRQYMKwYBBAGVEgECAwEBMDUwMwYIKwYBBQUHAgEWJ2h0 dHA6Ly9ldXJvcGtpLmlhaWsuYXQvY2EvaWFpay9jcHMvMS4zLzBIBgNVHR8EQTA/MD2gO6A5 hjdodHRwOi8vY2EuaWFpay50dWdyYXouYXQvY2Fwc28vY3Jscy9FdXJvUEtJSUFJS19TaWcu Y3JsMIGaBggrBgEFBQcBAQSBjTCBijBCBggrBgEFBQcwAYY2aHR0cDovL2NhLmlhaWsudHVn cmF6LmF0L2NhcHNvL09DU1A/Y2E9RXVyb1BLSUlBSUtfU2lnMEQGCCsGAQUFBzAChjhodHRw Oi8vY2EuaWFpay50dWdyYXouYXQvY2Fwc28vY2VydHMvRXVyb1BLSUlBSUtfU2lnLmNlcjAp BgNVHREEIjAggR5hbmRyZWFzLm5pZWRlcmxAaWFpay50dWdyYXouYXQwHwYDVR0jBBgwFoAU ru5VBhd6UxETGKukzhxxCRqDFPMwDQYJKoZIhvcNAQEFBQADggEBAKNGk4kNRRBbI09oCQXq Reb+mEu0hGHQozZt4BPg0AvUu1GG3rXknyhm+AEu1xkilPEaNjRYZ76/ax7HNt1I+5wD1agQ 5rx7WqO3ZC5xLgUagdIxVdGrTuokw6UP7s6ZplJsDL2f5xe2pF6q1HBFN4MGAxECt2v5uWNh dTzmOOpnvUyh1EGfo5PCGx54rsrhbTgX/lIFSTtksxj9jW+O/2bOY1IDiN8Mx20vynVLhQFC qTxYRr2oSR1nW2uJv+ruj7BOMOqZw3kyj6HfuTMmK2K9nChMZVRvrwRi+Jw0puT8HophhCaX oxXRCRFb2C5ngb9b/DELyBYSCrnh/tXvQYIxggKhMIICnQIBATCBuDCBrDEcMBoGA1UEAxMT RXVyb1BLSSBJQUlLIFNpZyBDQTEmMCQGA1UEChMdR3JheiBVbml2ZXJzaXR5IG9mIFRlY2hu b2xvZ3kxSDBGBgNVBAsTP0luc3RpdHV0ZSBmb3IgQXBwbGllZCBJbmZvcm1hdGlvbiBQcm9j ZXNzaW5nIGFuZCBDb21tdW5pY2F0aW9uczENMAsGA1UEBxMER3JhejELMAkGA1UEBhMCQVQC BwDSwWruQvMwCQYFKw4DAhoFAKCBvjAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqG SIb3DQEJBTEPFw0xMTA4MTIxNDM5MzdaMCMGCSqGSIb3DQEJBDEWBBSFkFhTt/Vs3loK24RA NMlBHV65RjBfBgkqhkiG9w0BCQ8xUjBQMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggq hkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJ KoZIhvcNAQEBBQAEggEASdCJMi8ZuZrImHY2Ibf6jWa4pZgVL+bJpGBDVqhiiTVRZ+ey5p3E yfde7vvxMRAXxoEYrDayfd5i09JXMZYKZS+ifVTAQadOOuQ4sZGDCUpMefDsupPstwGRi4v4 S/G/l9wJvROzJcwVIFue92+OS8IfXxAE5QWDYfe/d0C/v0C8kSypDwlTfR1OPn41L931D0K4 pW70s6owUZK1uJ4ab4Aa3J4lVsnKnLmqx5w+nbNBfQHVb4kuQiIUmgZaAXJqxyOxyNwsPvjH 6+CzUbavnjN3uht2lRTKc9JdhnaLZSuuI/Z8OVuOqAzvvtzJ5ymPRslMZ/zGoNxlOyVnZLjv LAAAAAAAAA== --------------ms020805030508090307000604--