From: Andreas Niederl <andreas.niederl@iaik.tugraz.at>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V7 13/13] Add a TPM backend null driver implementation
Date: Fri, 12 Aug 2011 16:55:06 +0200 [thread overview]
Message-ID: <4E453ECA.30707@iaik.tugraz.at> (raw)
In-Reply-To: <20110810193018.619841098@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi,
the null driver backend generates a warning for me on gcc-4.4.5:
cc1: warnings being treated as errors
/home/aniederl/work/actvsm/qemu/hw/tpm_null.c: In function ‘tpm_null_main_loop’:
/home/aniederl/work/actvsm/qemu/hw/tpm_null.c:107: error: ‘in’ may be used uninitialized in this function
make[1]: *** [tpm_null.o] Error 1
The attached patch fixes this.
Regards,
Andreas
[-- Attachment #2: qemu_tpm_be_null_init.diff --]
[-- Type: text/plain, Size: 646 bytes --]
commit a4f91be3b14c412d47a711505edf9be8816dde26
Author: Andreas Niederl <andreas.niederl@iaik.tugraz.at>
Date: Fri Aug 12 14:39:48 2011 +0200
Fix uninitialized variable warning in tpm_null driver
diff --git a/hw/tpm_null.c b/hw/tpm_null.c
index d8d4fda..ce0b8f0 100644
--- a/hw/tpm_null.c
+++ b/hw/tpm_null.c
@@ -97,6 +97,7 @@ static void *tpm_null_main_loop(void *d)
locty = thr_parms->tpm_state->command_locty;
+ in = thr_parms->tpm_state->loc[locty].w_buffer.buffer;
in_len = thr_parms->tpm_state->loc[locty].w_offset;
out = thr_parms->tpm_state->loc[locty].r_buffer.buffer;
next prev parent reply other threads:[~2011-08-12 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 19:29 [Qemu-devel] [PATCH V7 00/13] Qemu Trusted Platform Module (TPM) integration Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 01/13] Support for TPM command line options Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 02/13] Add TPM (frontend) hardware interface (TPM TIS) to Qemu Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 03/13] Add persistent state handling to TPM TIS frontend driver Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 04/13] Add tpm_tis driver to build process Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 05/13] Add a debug register Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 06/13] Add a TPM backend skeleton implementation Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 07/13] Implementation of the libtpms-based backend Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 08/13] Introduce file lock for the block layer Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 09/13] Add block storage support for libtpms based TPM backend Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 10/13] Encrypt state blobs using AES CBC encryption Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 11/13] Experimental support for block migrating TPMs state Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 12/13] Support for taking measurements when kernel etc. are passed to Qemu Stefan Berger
2011-08-12 15:12 ` Andreas Niederl
2011-08-14 20:18 ` Stefan Berger
2011-08-10 19:29 ` [Qemu-devel] [PATCH V7 13/13] Add a TPM backend null driver implementation Stefan Berger
2011-08-12 14:55 ` Andreas Niederl [this message]
2011-08-14 20:18 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E453ECA.30707@iaik.tugraz.at \
--to=andreas.niederl@iaik.tugraz.at \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).