From: Stefan Weil <weil@mail.berlios.de>
To: Andrzej Zaborowski <balrogg@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tcg/arm: Fix compiler error caused by unused function
Date: Sat, 13 Aug 2011 11:16:15 +0200 [thread overview]
Message-ID: <4E4640DF.1080801@mail.berlios.de> (raw)
In-Reply-To: <1311970049-5472-1-git-send-email-weil@mail.berlios.de>
Am 29.07.2011 22:07, schrieb Stefan Weil:
> Function tcg_out_addi is obviously unused and causes a compiler
> error (tested with cross compilation on x86 Debian Linux):
>
> tcg/arm/tcg-target.c:1824: error: ‘tcg_out_addi’ defined but not used
>
> Don't remove it because it might be useful in the future,
> but declare it inline. This fixes the compiler error and
> is similar to other tcg targets.
>
> Cc: Andrzej Zaborowski<balrogg@gmail.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
> tcg/arm/tcg-target.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 93eb0f1..c94a354 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1820,7 +1820,7 @@ static inline void tcg_out_st(TCGContext *s, TCGType type, int arg,
> tcg_out_st32(s, COND_AL, arg, arg1, arg2);
> }
>
> -static void tcg_out_addi(TCGContext *s, int reg, tcg_target_long val)
> +static inline void tcg_out_addi(TCGContext *s, int reg, tcg_target_long val)
> {
> if (val> 0)
> if (val< 0x100)
>
Ping?
next prev parent reply other threads:[~2011-08-13 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 20:07 [Qemu-devel] [PATCH] tcg/arm: Fix compiler error caused by unused function Stefan Weil
2011-08-13 9:16 ` Stefan Weil [this message]
2011-08-24 20:25 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4640DF.1080801@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).