From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions
Date: Sat, 13 Aug 2011 20:05:25 -0700 [thread overview]
Message-ID: <4E473B75.1050100@redhat.com> (raw)
In-Reply-To: <4E452F28.5000902@codemonkey.ws>
On 08/12/2011 06:48 AM, Anthony Liguori wrote:
>> target_phys_addr_t offset_in_region;
>> AddrRange addr;
>> uint8_t dirty_log_mask;
>> + bool readable;
> @@ -125,6 +125,7 @@ struct FlatRange {
>
> In a follow up, it might be good to add a comment explaining that this
> whole readable thing is not just an optimization, but a hard
> requirement for KVM in order to be able to execute code from ROM.
This has nothing to do with kvm (in fact, I think we cannot support it
under kvm with current interfaces). It's there to support devices that
sometimes act as RAM and sometimes as mmio.
We could also do it with a container and playing with subregions. I
tried it and it was pretty complicated.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-08-14 3:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 16:58 [Qemu-devel] [PATCH 0/3] Memory API updates Avi Kivity
2011-08-08 16:58 ` [Qemu-devel] [PATCH 1/3] memory: reclaim resources when a memory region is destroyed for good Avi Kivity
2011-08-08 16:58 ` [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions Avi Kivity
2011-08-12 13:48 ` Anthony Liguori
2011-08-14 3:05 ` Avi Kivity [this message]
2011-08-14 13:29 ` Anthony Liguori
2011-08-14 15:43 ` Alexander Graf
2011-08-14 13:51 ` Anthony Liguori
2011-08-08 16:58 ` [Qemu-devel] [PATCH 3/3] memory: correct documentation typos Avi Kivity
2011-08-12 13:47 ` [Qemu-devel] [PATCH 0/3] Memory API updates Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E473B75.1050100@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).