From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsfga-00037W-EK for qemu-devel@nongnu.org; Sun, 14 Aug 2011 14:45:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QsfgZ-0002VG-5X for qemu-devel@nongnu.org; Sun, 14 Aug 2011 14:45:24 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:62572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QsfgY-0002VC-T1 for qemu-devel@nongnu.org; Sun, 14 Aug 2011 14:45:23 -0400 Received: by pzk37 with SMTP id 37so7527719pzk.29 for ; Sun, 14 Aug 2011 11:45:22 -0700 (PDT) Message-ID: <4E47FB9C.2090805@codemonkey.ws> Date: Sun, 14 Aug 2011 11:45:16 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1313008408-23161-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1313008408-23161-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/8]: Introduce the RunState type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, armbru@redhat.com, avi@redhat.com, amit.shah@redhat.com On 08/10/2011 03:33 PM, Luiz Capitulino wrote: > It replaces the VMSTOP macros and allows us to drop some global variables. > > Additionally, the problem with issuing 'cont' when the VM is in bad state > is addressed and we make the current state available in QMP and HMP. > > changelog > --------- > > v2 > > o Rename the new type from QemuState to RunState > (also renames related functions) > o Rename the enum values to contain proper word seperation > o Redo patch 'Monitor: Don't allow cont on bad VM state' to not use a global > variable > o Make the current VM state also available in HMP > o Improve some commit logs a bit Really nice cleanup! Other than the few minor naming comments: Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > audio/audio.c | 2 +- > cpus.c | 22 ++++++++-------- > cpus.h | 1 - > gdbstub.c | 34 ++++++++++++------------ > hw/etraxfs_dma.c | 2 +- > hw/ide/ahci.c | 2 +- > hw/ide/core.c | 4 +- > hw/ide/internal.h | 3 +- > hw/ide/pci.c | 2 +- > hw/kvmclock.c | 5 ++- > hw/qxl.c | 3 +- > hw/scsi-disk.c | 4 +- > hw/virtio-blk.c | 5 ++- > hw/virtio.c | 4 +- > hw/watchdog.c | 2 +- > kvm-all.c | 2 +- > migration.c | 14 ++++++--- > monitor.c | 22 +++++++++++---- > qemu-timer.c | 11 ++++--- > qerror.c | 4 +++ > qerror.h | 3 ++ > qmp-commands.hx | 21 ++++++++++++++- > savevm.c | 8 +++--- > sysemu.h | 40 +++++++++++++++++++--------- > target-i386/kvm.c | 4 +- > ui/sdl.c | 6 ++-- > ui/spice-display.c | 3 +- > vl.c | 71 +++++++++++++++++++++++++++++++++++++++++++-------- > xen-all.c | 8 +++-- > 29 files changed, 211 insertions(+), 101 deletions(-) > >