From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsh96-0001RD-9j for qemu-devel@nongnu.org; Sun, 14 Aug 2011 16:18:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qsh95-0000iQ-DV for qemu-devel@nongnu.org; Sun, 14 Aug 2011 16:18:56 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:58726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsh95-0000iA-B4 for qemu-devel@nongnu.org; Sun, 14 Aug 2011 16:18:55 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7EJqZ1F022600 for ; Sun, 14 Aug 2011 15:52:35 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7EKIrAY267046 for ; Sun, 14 Aug 2011 16:18:53 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7EKIrVr000364 for ; Sun, 14 Aug 2011 16:18:53 -0400 Message-ID: <4E482DA2.4060703@linux.vnet.ibm.com> Date: Sun, 14 Aug 2011 16:18:42 -0400 From: Stefan Berger MIME-Version: 1.0 References: <20110810192919.425976163@linux.vnet.ibm.com> <20110810193018.029981610@linux.vnet.ibm.com> <4E4542E9.9060000@iaik.tugraz.at> In-Reply-To: <4E4542E9.9060000@iaik.tugraz.at> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 12/13] Support for taking measurements when kernel etc. are passed to Qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas Niederl Cc: qemu-devel@nongnu.org On 08/12/2011 11:12 AM, Andreas Niederl wrote: > Hi, > the SHA1_HashBuf function you are using originates from a non-public > internal API which gets packaged on Fedora but is not available at least > on Debian (Squeeze) and Gentoo. > Well, it's not a private API but it's part of freebl and packaged in FC or RHEL as nss-softokn-freebl(-devel). It still requires 'pkg-config nss-softokn' to provide the path to includes etc.. I could not find this package in Ubuntu, either. So that may also be a problem then for libtpms, which depends on freebl. > Could you please use HASH_HashBuf(HASH_AlgSHA1,...) which is available > on more platforms? > The attached patch would do this. I'll use this API. This will make the patch a lot simpler since it will only require 'nss' to be available. > I'm not familiar with Fedora's nss packaging but maybe you can also drop > the check for nss-softokn in favor of nss with pkg-config. > Will do. Thanks for reviewing / testing. Regards, Stefan > Regards, > Andreas