From: Richard Henderson <rth@twiddle.net>
To: khansa@kics.edu.pk
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi,
qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/4] Octeon cpu definitions in target-mips and Octeon specific changes in set_thread_area syscall
Date: Mon, 15 Aug 2011 08:43:43 -0700 [thread overview]
Message-ID: <4E493EAF.3090207@twiddle.net> (raw)
In-Reply-To: <1313407533-25740-3-git-send-email-khansa@kics.edu.pk>
On 08/15/2011 04:25 AM, khansa@kics.edu.pk wrote:
> ((CPUMIPSState *) cpu_env)->tls_value = arg1;
> + if (((CPUMIPSState *) cpu_env)->insn_flags & CPU_OCTEON) {
> + /* tls entry is moved to k0 so that this can be used later
> + currently this thing is tested only for Octeon */
> + ((CPUMIPSState *) cpu_env)->active_tc.gpr[26] = arg1;
> + }
You wanted INSN_OCTEON, not CPU_OCTEON, which includes CPU_MIPS64R2.
That said, this is *not* in the current linux kernel. And I question
the wisdom of changing the user-space ABI for TLS for a single CPU.
I think you'd better leave this out until it's actually accepted upstream.
r~
next prev parent reply other threads:[~2011-08-15 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 11:25 [Qemu-devel] [PATCH 0/4] MIPS64 user mode emulation in QEMU with Cavium specific instruction support khansa
2011-08-15 11:25 ` [Qemu-devel] [PATCH 1/4] linux-user:Support for MIPS64 user mode emulation in QEMU khansa
2011-08-15 15:32 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 2/4] Octeon cpu definitions in target-mips and Octeon specific changes in set_thread_area syscall khansa
2011-08-15 15:43 ` Richard Henderson [this message]
2011-08-17 7:00 ` Khansa Butt
2011-08-17 15:03 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 3/4] target-mips:Support for Cavium specific instructions khansa
2011-08-15 16:18 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler khansa
2011-08-15 16:37 ` Richard Henderson
2011-08-17 6:52 ` Khansa Butt
2011-08-17 15:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E493EAF.3090207@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=khansa@kics.edu.pk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).