From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qt0ly-0006Eq-14 for qemu-devel@nongnu.org; Mon, 15 Aug 2011 13:16:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qt0lw-0000JI-Ri for qemu-devel@nongnu.org; Mon, 15 Aug 2011 13:16:22 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:60702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qt0lw-0000Ik-PD for qemu-devel@nongnu.org; Mon, 15 Aug 2011 13:16:20 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7FH2pxO008023 for ; Mon, 15 Aug 2011 13:02:51 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7FHF59l358904 for ; Mon, 15 Aug 2011 13:15:29 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7FHF49F018892 for ; Mon, 15 Aug 2011 14:15:04 -0300 Message-ID: <4E495411.1030905@us.ibm.com> Date: Mon, 15 Aug 2011 12:14:57 -0500 From: Adam Litke MIME-Version: 1.0 References: <1313416732-25133-1-git-send-email-jyang@redhat.com> <4E491DC1.2000204@redhat.com> <4E4948FF.3090804@us.ibm.com> <20110815165042.GD24615@redhat.com> In-Reply-To: <20110815165042.GD24615@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: libvir-list@redhat.com, qemu-devel On 08/15/2011 11:50 AM, Daniel P. Berrange wrote: > On Mon, Aug 15, 2011 at 11:27:43AM -0500, Adam Litke wrote: >> On 08/15/2011 08:23 AM, Osier Yang wrote: >>> =E4=BA=8E 2011=E5=B9=B408=E6=9C=8815=E6=97=A5 21:58, Osier Yang =E5=86= =99=E9=81=93: >>>> * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as >>>> "balloon: actual=3D", which cause "actual=3D" is stripped early befo= re >>>> the real parsing. This patch changes BALLOON_PREFIX into "balloon: "= , >>>> and modifies related functions, also renames >>>> "qemuMonitorParseExtraBalloonInfo" to "qemuMonitorParseBalloonInfo", >>>> as after the changing, it parses all the info returned by "info ball= oon". >>> >>> Forgot to mention the problem, e.g. "virsh dommemstat $domain" return= s empty >>> result. >> >> That is because qemu has disabled stats reporting and so the extra >> fields are not present in the info balloon response. >=20 > I'd completely forgotten about this problem. We really should try to > get this fixed & renabled in QEMU sometime in the not too distant > future. I agree. The problem is that qemu lacks a proper interface for asynchronous commands so an unresponsive guest could freeze the monitor. QMP is undergoing a significant overhaul as a result of the new QAPI framework. It is my understanding that this new framework will provide a robust async interface, allowing us to re-enable balloon stats. --=20 Adam Litke IBM Linux Technology Center