From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qtga3-0005BR-Bv
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 09:54:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qtga2-0000dr-5M
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 09:54:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44296)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qtga1-0000dm-Te
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 09:54:50 -0400
Message-ID: <4E4BC826.4010608@redhat.com>
Date: Wed, 17 Aug 2011 06:54:46 -0700
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1313513145-5348-1-git-send-email-rth@twiddle.net>
	<1313513145-5348-12-git-send-email-rth@twiddle.net>
In-Reply-To: <1313513145-5348-12-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/14] pc: Convert port92 to
	isa_register_ioport.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 08/16/2011 09:45 AM, Richard Henderson wrote:
> +static const MemoryRegionPortio port92_portio[] = {
> +    {0, 1, 1, .read = port92_read, .write = port92_write },

A space character died here.

> +    PORTIO_END_OF_LIST(),
> +};
> +
> +static const MemoryRegionOps port92_ops = {
> +    .old_portio = port92_portio
> +};
> +
>

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.