From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtgoa-0001dV-RA for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QtgoU-0003l8-O5 for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:09:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtgoU-0003l4-Fr for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:09:46 -0400 Message-ID: <4E4BCBA6.9070109@redhat.com> Date: Wed, 17 Aug 2011 07:09:42 -0700 From: Avi Kivity MIME-Version: 1.0 References: <1313513145-5348-1-git-send-email-rth@twiddle.net> <1313513145-5348-3-git-send-email-rth@twiddle.net> <4E4BC5FA.1020409@redhat.com> <4E4BC711.7050402@redhat.com> <4E4BCAD4.6080103@twiddle.net> In-Reply-To: <4E4BCAD4.6080103@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/14] isa: Add isa_register_old_portio_list(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 08/17/2011 07:06 AM, Richard Henderson wrote: > On 08/17/2011 06:50 AM, Avi Kivity wrote: > > Oh, after seeing a user I see how it works now. But can't we derive > > this information instead of forcing the user to specify it? > > I thought about that, but then when I went to implement I found it > just as easy to have the user specify it. With the later I get to > re-use the pieces of the read-only memory. > Yes, question is, will the user get the rules where you need to stick an P_E_O_L() (between any contiguous block, yes?). I guess we can get away with just documenting it. The list of users is unlikely to grow. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.