From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtgwv-0005o9-1h for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:18:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qtgwp-0005Jk-TP for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:18:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtgwp-0005Jg-MT for qemu-devel@nongnu.org; Wed, 17 Aug 2011 10:18:23 -0400 Message-ID: <4E4BCDAC.6020501@redhat.com> Date: Wed, 17 Aug 2011 07:18:20 -0700 From: Avi Kivity MIME-Version: 1.0 References: <1313513145-5348-1-git-send-email-rth@twiddle.net> <1313513145-5348-14-git-send-email-rth@twiddle.net> <4E4BCA67.4090202@redhat.com> <4E4BCC05.2070806@twiddle.net> In-Reply-To: <4E4BCC05.2070806@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 08/17/2011 07:11 AM, Richard Henderson wrote: > On 08/17/2011 07:04 AM, Avi Kivity wrote: > > Which PCI-ISA bridge? > > The only implied by isa_bus_new. > > > If you're behind a secondary PCI bridge, you've now bypassed its filtering. > > ... Which we never will be, since the PCI-ISA bridge is not explicitly emulated, > but only implied via the way we mash things together inside QEMU. Right. The patch is broken, but no brokener than what we had before; I think we can/should leave any cleanups until later. > Clearly I shouldn't have used the word, as it's confusing. > > -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.