From: Richard Henderson <rth@twiddle.net>
To: Khansa Butt <khansa@kics.edu.pk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler
Date: Wed, 17 Aug 2011 08:18:42 -0700 [thread overview]
Message-ID: <4E4BDBD2.7010309@twiddle.net> (raw)
In-Reply-To: <CAAoJSP5jsE3AkZrsq1B9t7iH2CDbiEPDVV-EGzRvcMqBgQt4jA@mail.gmail.com>
On 08/16/2011 11:52 PM, Khansa Butt wrote:
> If I pass env->insn_flags to target_disas() how can I pass this flag info
> from disas.c to mips-dis.c. can i do following thing for MIPS in disas.c
> if (flags & 0xFFFF) {
> disasm_info.mach = flags & 0xFFFF;
Well, I'd have written this as
disasm_info.mach = flags;
I see no reason for the AND or IF.
> how can I make mips-defs.h 's definitions visible to mips-dis.c?
#include?
r~
prev parent reply other threads:[~2011-08-17 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 11:25 [Qemu-devel] [PATCH 0/4] MIPS64 user mode emulation in QEMU with Cavium specific instruction support khansa
2011-08-15 11:25 ` [Qemu-devel] [PATCH 1/4] linux-user:Support for MIPS64 user mode emulation in QEMU khansa
2011-08-15 15:32 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 2/4] Octeon cpu definitions in target-mips and Octeon specific changes in set_thread_area syscall khansa
2011-08-15 15:43 ` Richard Henderson
2011-08-17 7:00 ` Khansa Butt
2011-08-17 15:03 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 3/4] target-mips:Support for Cavium specific instructions khansa
2011-08-15 16:18 ` Richard Henderson
2011-08-15 11:25 ` [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in disassembler khansa
2011-08-15 16:37 ` Richard Henderson
2011-08-17 6:52 ` Khansa Butt
2011-08-17 15:18 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4BDBD2.7010309@twiddle.net \
--to=rth@twiddle.net \
--cc=khansa@kics.edu.pk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).