From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QthtH-0000vJ-MC
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:18:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QthtG-0006lU-Jj
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:18:47 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:65291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QthtG-0006lP-G6
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:18:46 -0400
Received: by vxi32 with SMTP id 32so1021696vxi.4
	for <qemu-devel@nongnu.org>; Wed, 17 Aug 2011 08:18:46 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E4BDBD2.7010309@twiddle.net>
Date: Wed, 17 Aug 2011 08:18:42 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1313407533-25740-1-git-send-email-khansa@kics.edu.pk>
	<1313407533-25740-5-git-send-email-khansa@kics.edu.pk>
	<4E494B62.9040407@twiddle.net>
	<CAAoJSP5jsE3AkZrsq1B9t7iH2CDbiEPDVV-EGzRvcMqBgQt4jA@mail.gmail.com>
In-Reply-To: <CAAoJSP5jsE3AkZrsq1B9t7iH2CDbiEPDVV-EGzRvcMqBgQt4jA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] Addition of Cavium instruction in
	disassembler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Khansa Butt <khansa@kics.edu.pk>
Cc: qemu-devel@nongnu.org

On 08/16/2011 11:52 PM, Khansa Butt wrote:
>  If I pass env->insn_flags to target_disas() how can I pass this flag info
> from disas.c to mips-dis.c. can i do following thing for MIPS in disas.c
> if (flags & 0xFFFF) {
>         disasm_info.mach = flags & 0xFFFF;

Well, I'd have written this as

  disasm_info.mach = flags;

I see no reason for the AND or IF.

> how can I make mips-defs.h 's definitions visible to mips-dis.c?

#include?



r~