qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Erik Rull <erik.rull@rdsoftware.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] USB port NULL pointer causes segv
Date: Wed, 17 Aug 2011 18:24:48 +0200	[thread overview]
Message-ID: <4E4BEB50.2080800@rdsoftware.de> (raw)

Hi all,

in usb-linux.c my qemu crashes in
static int usb_host_open(USBHostDevice *dev, int bus_num, int addr, char 
*port, const char *prod_name, int speed)

because port is NULL.

The line that causes the problem is:
strcpy(dev->port, port);

All Ports are displayed in the qemu monitor info as (null)

when changing the line to:
     if (port)
       strcpy(dev->port, port);
     else
       dev->port[0] = '\0';

everything is fine :-)

Please check this issue and let me know if my workaround is okay.

Best regards,

Erik

             reply	other threads:[~2011-08-17 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 16:24 Erik Rull [this message]
2011-08-17 21:43 ` [Qemu-devel] USB port NULL pointer causes segv Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2011-08-18 11:50 erik.rull
2011-08-21 15:29 Erik Rull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4BEB50.2080800@rdsoftware.de \
    --to=erik.rull@rdsoftware.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).