From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode
Date: Wed, 17 Aug 2011 16:48:01 -0700 [thread overview]
Message-ID: <4E4C5331.3070209@redhat.com> (raw)
In-Reply-To: <4E4C50F6.20208@redhat.com>
On 08/17/2011 04:38 PM, Avi Kivity wrote:
>
> The mmio code has
>
> s->plane_updated |= mask; /* only used to detect font
> change */
>
> aren't we losing it? we could easily recover it via dirty logging.
>
We can't really recover it. So I think we need to restrict the
optimization to graphic mode.
Is grub using text mode or graphic mode?
If it's using text mode, it may be faster to compare the font plane to a
snapshot from the last redraw than to take an exit.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-08-17 23:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 22:40 [Qemu-devel] [PATCH v2 0/6] vga: dirty log cleanup, more linear mapping Jan Kiszka
2011-08-17 22:40 ` [Qemu-devel] [PATCH v2 1/6] vmware-vga: Register reset service Jan Kiszka
2011-08-17 22:40 ` [Qemu-devel] [PATCH v2 2/6] vmware-vga: Disable verbose mode Jan Kiszka
2011-08-17 22:41 ` [Qemu-devel] [PATCH v2 3/6] vmware-vga: Remove dead DIRECT_VRAM mode Jan Kiszka
2011-08-17 22:41 ` [Qemu-devel] [PATCH v2 4/6] vmware-vga: Eliminate vga_dirty_log_restart Jan Kiszka
2011-08-17 22:41 ` [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode Jan Kiszka
2011-08-17 23:38 ` Avi Kivity
2011-08-17 23:48 ` Avi Kivity [this message]
2011-08-18 22:26 ` Jan Kiszka
2011-08-19 15:19 ` Avi Kivity
2011-08-19 21:26 ` Jan Kiszka
2011-08-17 22:41 ` [Qemu-devel] [PATCH v2 6/6] vga: Drop some unused fields Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4C5331.3070209@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).