From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtpqF-0007iY-HL for qemu-devel@nongnu.org; Wed, 17 Aug 2011 19:48:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QtpqA-0008Ri-Kb for qemu-devel@nongnu.org; Wed, 17 Aug 2011 19:48:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qtpq9-0008Qp-RH for qemu-devel@nongnu.org; Wed, 17 Aug 2011 19:48:06 -0400 Message-ID: <4E4C5331.3070209@redhat.com> Date: Wed, 17 Aug 2011 16:48:01 -0700 From: Avi Kivity MIME-Version: 1.0 References: <4da1c5e91e8f61b6c17aa0756006d030013bedd8.1313620857.git.jan.kiszka@web.de> <4E4C50F6.20208@redhat.com> In-Reply-To: <4E4C50F6.20208@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel , Gerd Hoffmann On 08/17/2011 04:38 PM, Avi Kivity wrote: > > The mmio code has > > s->plane_updated |= mask; /* only used to detect font > change */ > > aren't we losing it? we could easily recover it via dirty logging. > We can't really recover it. So I think we need to restrict the optimization to graphic mode. Is grub using text mode or graphic mode? If it's using text mode, it may be faster to compare the font plane to a snapshot from the last redraw than to take an exit. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.