From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuB2p-0002n6-Et for qemu-devel@nongnu.org; Thu, 18 Aug 2011 18:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QuB2o-0005y4-9p for qemu-devel@nongnu.org; Thu, 18 Aug 2011 18:26:35 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:50221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuB2n-0005xo-Sv for qemu-devel@nongnu.org; Thu, 18 Aug 2011 18:26:34 -0400 Message-ID: <4E4D9190.5090309@web.de> Date: Thu, 18 Aug 2011 15:26:24 -0700 From: Jan Kiszka MIME-Version: 1.0 References: <4da1c5e91e8f61b6c17aa0756006d030013bedd8.1313620857.git.jan.kiszka@web.de> <4E4C50F6.20208@redhat.com> <4E4C5331.3070209@redhat.com> In-Reply-To: <4E4C5331.3070209@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB97108DDD96668F2A8EEC785" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , qemu-devel , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB97108DDD96668F2A8EEC785 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-08-17 16:48, Avi Kivity wrote: > On 08/17/2011 04:38 PM, Avi Kivity wrote: >> >> The mmio code has >> >> s->plane_updated |=3D mask; /* only used to detect font >> change */ >> >> aren't we losing it? we could easily recover it via dirty logging. >> Yes, I forgot to forward-port plane_updated =3D 0xf from v1 of the patch.= >=20 > We can't really recover it. I don't see yet why we should not if we simply enforce a full update. Can you elaborate? > So I think we need to restrict the > optimization to graphic mode. >=20 > Is grub using text mode or graphic mode? >=20 > If it's using text mode, it may be faster to compare the font plane to = a > snapshot from the last redraw than to take an exit. I wasn't optimizing for text mode here, it's just a side effect if it happens to benefit from it as well. I could exclude it, but only if really needed. Jan --------------enigB97108DDD96668F2A8EEC785 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5NkZIACgkQitSsb3rl5xR4cQCfT9L80SXyTSbKP5SmvxyZ3Wrz 1xcAoNsA25M7KMsBd7CMUtCiGXY3Hhxu =1MEU -----END PGP SIGNATURE----- --------------enigB97108DDD96668F2A8EEC785--