From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QuQxg-0002Ew-6g
	for qemu-devel@nongnu.org; Fri, 19 Aug 2011 11:26:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QuQxf-0003Ze-71
	for qemu-devel@nongnu.org; Fri, 19 Aug 2011 11:26:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16672)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QuQxe-0003ZX-UI
	for qemu-devel@nongnu.org; Fri, 19 Aug 2011 11:26:19 -0400
Message-ID: <4E4E808C.4000205@redhat.com>
Date: Fri, 19 Aug 2011 08:26:04 -0700
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20110704094358.GA10960@redhat.com>
	<4E4B7DE1.3050405@cn.fujitsu.com>
	<4E4C8577.5000608@cn.fujitsu.com> <4E4D2C9F.6040805@redhat.com>
	<4E4DF0A0.6000108@cn.fujitsu.com>
In-Reply-To: <4E4DF0A0.6000108@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pci: add standard bridge device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 08/18/2011 10:12 PM, Wen Congyang wrote:
> >>
> >>  The following patch can fix this problem, but I'm not sure whether it
> >>  is right.
> >
> >  It's correct but insufficient, the filtering code (pci_bridge_filter)
> >  needs to be updated to use the memory API.
>
> I read the function pci_bridge_filter(), and the function only read
> PCI bridge's config space(command, base and limit). If base>  limit,
> it will set addr to PCI_BAR_UNMAPPED.
>
> I do not find anything that needs to updated to use the memory API.

Currently it doesn't do any filtering at all.  Bridges need to create a 
new address space, then attach aliases of this region (corresponding to 
the filtered area and to the legacy vga space) to the parent bus' 
address space.

> I add a scsi controller on pci bus1, and a scsi disk on this controller.
> I can read and write this disk, and I do not meet any problem.
>

However, filtering doesn't work.  You could put a BAR outside the 
filtered area and it would be visible to the guest.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.