qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bob Breuer <breuerr@mc.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] sparc32_dma: correctly initialize ledma base address
Date: Sat, 20 Aug 2011 00:04:01 -0500	[thread overview]
Message-ID: <4E4F4041.5000208@mc.net> (raw)
In-Reply-To: <4E4ECD0A.70207@siriusit.co.uk>

Mark Cave-Ayland wrote:
> On 15/08/11 16:38, Bob Breuer wrote:
> 
>> Depends on the rom.  The SS-5 rom always sets it correctly, whereas the
>> SS-20 rom only sets it when you do "boot net".  Also, this is just the
>> top 8 bits of the address.  The DMA2 documentation[1] for E_BASE_ADDR
>> states that these upper address bits default to 0xff, even though it
>> seems to incorrectly define it as bits 7:0 in the register instead of
>> 31:24.
> 
> Nice one - looks like I missed this when reading the documentation. At
> least the choice of default address now makes sense.

It might also make sense to modify the dma address calculations to use
only the top 8 bits from ledma.  Not sure if anything will care about
that though.

>> If you follow Artyom's blog, at [2] it was assumed that the bogus dbri
>> device was the culprit (which is also why I went down the path of
>> implementing the dbri device), when in reality, the selftest failure
>> was preventing "boot net" from running and fixing the ledma register
>> settings.
> 
> Okay - I think I see ;)  In that case, I'd say this patch should be
> applied if Blue hasn't already done it (*sigh* I really miss the git web
> interface on qemu.org).

http://repo.or.cz/w/qemu.git  might be the next best thing, not sure if
there is a mirroring delay with it or not.

Bob

  reply	other threads:[~2011-08-20  5:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 16:11 [Qemu-devel] sparc32_dma: correctly initialize ledma base address Bob Breuer
2011-08-15 10:14 ` Mark Cave-Ayland
2011-08-15 15:38   ` Bob Breuer
2011-08-19 20:52     ` Mark Cave-Ayland
2011-08-20  5:04       ` Bob Breuer [this message]
2011-08-20  7:09         ` Blue Swirl
2011-08-26  9:54     ` Artyom Tarasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4F4041.5000208@mc.net \
    --to=breuerr@mc.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).