From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qurtp-0000Mf-5W
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 16:12:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qurto-0002D4-AV
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 16:12:09 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:35180)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qurto-0002D0-7D
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 16:12:08 -0400
Received: by vws17 with SMTP id 17so3540322vws.4
	for <qemu-devel@nongnu.org>; Sat, 20 Aug 2011 13:12:07 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E501514.9090508@twiddle.net>
Date: Sat, 20 Aug 2011 13:12:04 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1313852195-23081-1-git-send-email-hpoussin@reactos.org>
	<1313852195-23081-7-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1313852195-23081-7-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus
 bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On 08/20/2011 07:56 AM, Hervé Poussineau wrote:
> +    memory_region_init(&s->isa_mem_space, "isa-memory", 0x00100000);
> +    memory_region_add_subregion(get_system_memory(),
> +                                APB_PCI_IO_BASE,
> +                                &s->isa_mem_space);

You should be passing on, or adding this subregion to, the PCI
memory region.  Unfortunately, apb_pci.c hasn't been converted
to the new api yet...


r~