From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42463)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QuyRM-0001MX-Or
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 23:11:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QuyRL-0000Nz-C9
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 23:11:12 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:57691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QuyRL-0000Nv-9U
	for qemu-devel@nongnu.org; Sat, 20 Aug 2011 23:11:11 -0400
Received: by gwb19 with SMTP id 19so2893516gwb.4
	for <qemu-devel@nongnu.org>; Sat, 20 Aug 2011 20:11:10 -0700 (PDT)
Message-ID: <4E50774B.9030901@codemonkey.ws>
Date: Sat, 20 Aug 2011 22:11:07 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1313689697-23627-1-git-send-email-avi@redhat.com>	<CAFEAcA8Hfqp0SHsnZ5UPP64b46StzvXLSMAUJWUut4vHBer8HQ@mail.gmail.com>	<4E4E7FCE.5050108@redhat.com>
	<CAAu8pHsFsra=yC9MVPJwAuZwkm+2h90hYJ19SCR8oBh92S0eUQ@mail.gmail.com>
In-Reply-To: <CAAu8pHsFsra=yC9MVPJwAuZwkm+2h90hYJ19SCR8oBh92S0eUQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Wire g_new() and friends to the
 qemu_malloc() family
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On 08/20/2011 01:59 AM, Blue Swirl wrote:
> On Fri, Aug 19, 2011 at 3:22 PM, Avi Kivity<avi@redhat.com>  wrote:
>> On 08/18/2011 09:54 PM, Peter Maydell wrote:
>>>
>>> On 18 August 2011 18:48, Avi Kivity<avi@redhat.com>    wrote:
>>>>   +static GMemVTable gmemvtable = {
>>>>   +    .malloc = qemu_malloc,
>>>>   +    .realloc = qemu_realloc,
>>>>   +    .free = qemu_free,
>>>>   +};
>>>>   +
>>>>   +/**
>>>>   + * qemu_malloc_init: initialize memory management
>>>>   + */
>>>>   +void qemu_malloc_init(void)
>>>>   +{
>>>>   +    g_mem_set_vtable(&gmemvtable);
>>>>   +}
>>>
>>> Does this mean you can now safely allocate with g_malloc
>>> and free with qemu_free, or is mixing the two APIs like that
>>> still a no-no ?
>>
>> You can, but I'd forbid it.  Mixing layers can only lead to tears later on.
>>
>> Best would be to convert qemu_malloc()s to g_new()s and g_malloc()s to
>> reduce confusion.
>
> Also plain malloc() and friends, except in tracing back end for obvious reasons.

sed script:

s:qemu_mallocz\( *\)(:g_malloc0\1\(:g
s:qemu_malloc\( *\)(:g_malloc\1\(:g
s:qemu_free\( *\)(:g_free\1\(:g
s:qemu_strdup\( *\)(:g_strdup\1\(:g
s:qemu_strndup\( *\)(:g_strndup\1\(:g

It takes a little build magic too to make sure everything has access to 
glib.

The patch is way too large to post.  Please speak now if you have an 
objection otherwise I'll commit in a couple days.

http://repo.or.cz/w/qemu/aliguori.git/commit/5cc99cedb46b3916dae8a565d5ffc5fb2f2e9bd6

If anyone wants to try it out first.

Regards,

Anthony Liguori