From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvUp1-00055t-Ik
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:45:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvUoz-0006uS-AP
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:45:47 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:51151)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvUoz-0006uI-7w
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:45:45 -0400
Received: by ywf9 with SMTP id 9so4154771ywf.4
	for <qemu-devel@nongnu.org>; Mon, 22 Aug 2011 06:45:44 -0700 (PDT)
Message-ID: <4E525D87.8010400@codemonkey.ws>
Date: Mon, 22 Aug 2011 08:45:43 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1314018774-27482-1-git-send-email-aliguori@us.ibm.com>	<1314018774-27482-2-git-send-email-aliguori@us.ibm.com>
	<4E525C5A.8000208@redhat.com>
In-Reply-To: <4E525C5A.8000208@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to
 g_io_add_watch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 08/22/2011 08:40 AM, Paolo Bonzini wrote:
> On 08/22/2011 03:12 PM, Anthony Liguori wrote:
>> I'm pretty sure that this will work on Win32, but I would appreciate
>> some help
>> testing. I think the semantics of g_io_channel_unix_new() are really
>> just tied
>> to the notion of a "unix fd" and not necessarily unix itself.
>
> Almost: in Win32 you need to use g_io_channel_win32_new_socket. But
> indeed on Windows you can only use qemu_set_fd_handler for sockets too.

I think that's really only for read/write though.  If you're just 
polling on I/O, it shouldn't matter IIUC.

If someone has a Windows box, they can confirm/deny by using qemu 
-monitor tcp:localhost:1024,socket,nowait with this patch.

Regards,

Anthony Liguori

>
> Paolo
>