From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvUr9-0006hJ-7E for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvUr8-0007X0-Ad for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:47:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvUr8-0007Wn-26 for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:47:58 -0400 Message-ID: <4E525E09.2000107@redhat.com> Date: Mon, 22 Aug 2011 15:47:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1314018774-27482-1-git-send-email-aliguori@us.ibm.com> <1314018774-27482-2-git-send-email-aliguori@us.ibm.com> <4E525C5A.8000208@redhat.com> <4E525D87.8010400@codemonkey.ws> In-Reply-To: <4E525D87.8010400@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Anthony Liguori , qemu-devel@nongnu.org On 08/22/2011 03:45 PM, Anthony Liguori wrote: >> >> Almost: in Win32 you need to use g_io_channel_win32_new_socket. But >> indeed on Windows you can only use qemu_set_fd_handler for sockets too. > > I think that's really only for read/write though. If you're just > polling on I/O, it shouldn't matter IIUC. > > If someone has a Windows box, they can confirm/deny by using qemu > -monitor tcp:localhost:1024,socket,nowait with this patch. Actually you're right, it works automagically: * On Win32, this can be used either for files opened with the MSVCRT * (the Microsoft run-time C library) _open() or _pipe, including file * descriptors 0, 1 and 2 (corresponding to stdin, stdout and stderr), * or for Winsock SOCKETs. If the parameter is a legal file * descriptor, it is assumed to be such, otherwise it should be a * SOCKET. This relies on SOCKETs and file descriptors not * overlapping. If you want to be certain, call either * g_io_channel_win32_new_fd() or g_io_channel_win32_new_socket() * instead as appropriate. So this patch would even let interested people enable exec migration on Windows. Paolo