From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Patrick Jackson <patricksjackson@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device.
Date: Mon, 22 Aug 2011 16:15:09 +0200 [thread overview]
Message-ID: <4E52646D.50605@redhat.com> (raw)
In-Reply-To: <CAJSP0QX3xnD1ZZjWO07XphvwtwMyC8bF8eNJ=2DoYoPTnWhR6A@mail.gmail.com>
On 08/22/2011 01:59 PM, Stefan Hajnoczi wrote:
> > + DEFINE_PROP_INT32("fd", GoldfishMemlogDevice, fd, -1),
> I'm not sure these fields all need to be defined here. Why make fd a
> qdev property?
I agree fd doesn't make much sense, but we may want to make it a chardev.
Paolo
prev parent reply other threads:[~2011-08-22 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 9:39 [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device Patrick Jackson
2011-08-22 11:59 ` Stefan Hajnoczi
2011-08-22 14:15 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52646D.50605@redhat.com \
--to=pbonzini@redhat.com \
--cc=patricksjackson@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).