From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QvVHc-0000Sx-Av
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:15:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QvVHY-0005eu-Gj
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:15:20 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:39507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QvVHY-0005eo-AX
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:15:16 -0400
Received: by yxt3 with SMTP id 3so4175773yxt.4
	for <qemu-devel@nongnu.org>; Mon, 22 Aug 2011 07:15:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E52646D.50605@redhat.com>
Date: Mon, 22 Aug 2011 16:15:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAKspZ_sLrHKBg7VCAoikeFR+kRygYd1wWchBO4Bow2Sq5Ng6rw@mail.gmail.com>
	<CAJSP0QX3xnD1ZZjWO07XphvwtwMyC8bF8eNJ=2DoYoPTnWhR6A@mail.gmail.com>
In-Reply-To: <CAJSP0QX3xnD1ZZjWO07XphvwtwMyC8bF8eNJ=2DoYoPTnWhR6A@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger
	device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Patrick Jackson <patricksjackson@gmail.com>

On 08/22/2011 01:59 PM, Stefan Hajnoczi wrote:
> >  +        DEFINE_PROP_INT32("fd", GoldfishMemlogDevice, fd, -1),
> I'm not sure these fields all need to be defined here.  Why make fd a
> qdev property?

I agree fd doesn't make much sense, but we may want to make it a chardev.

Paolo