From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Patrick Jackson <patricksjackson@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.
Date: Mon, 22 Aug 2011 16:16:21 +0200 [thread overview]
Message-ID: <4E5264B5.4010002@redhat.com> (raw)
In-Reply-To: <CAJSP0QWYeKas=GhfwGXV8uR61P1PueD4_S9ZQ1RTNOxGXHV1qQ@mail.gmail.com>
On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote:
> Please use the block layer instead of reinventing portable file I/O.
>
> Also, please check which of the utility functions already exist in
> QEMU. If a utility function in this patch is needed it should be made
> generic for all of QEMU, not just goldfish or nand.
This was part of the plans, but there was no time for it.
Paolo
next prev parent reply other threads:[~2011-08-22 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 9:39 [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller Patrick Jackson
2011-08-22 12:04 ` Stefan Hajnoczi
2011-08-22 14:16 ` Paolo Bonzini [this message]
2011-08-22 20:41 ` Stefan Hajnoczi
2011-08-23 7:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5264B5.4010002@redhat.com \
--to=pbonzini@redhat.com \
--cc=patricksjackson@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).