From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvVIh-000172-BT for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:16:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvVIg-0005lh-6Y for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:16:27 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:38671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvVIg-0005lb-2M for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:16:26 -0400 Received: by gxk26 with SMTP id 26so4267696gxk.4 for ; Mon, 22 Aug 2011 07:16:25 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E5264B5.4010002@redhat.com> Date: Mon, 22 Aug 2011 16:16:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Patrick Jackson On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: > Please use the block layer instead of reinventing portable file I/O. > > Also, please check which of the utility functions already exist in > QEMU. If a utility function in this patch is needed it should be made > generic for all of QEMU, not just goldfish or nand. This was part of the plans, but there was no time for it. Paolo