From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvVi6-0003A6-53 for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:42:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvVi0-0003N1-JU for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:42:42 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:51288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvVi0-0003MW-E9 for qemu-devel@nongnu.org; Mon, 22 Aug 2011 10:42:36 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7MEdNm4007994 for ; Mon, 22 Aug 2011 08:39:23 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p7MEgVhn161272 for ; Mon, 22 Aug 2011 08:42:31 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7M8gU8Y014699 for ; Mon, 22 Aug 2011 02:42:30 -0600 Message-ID: <4E526AD5.3000005@us.ibm.com> Date: Mon, 22 Aug 2011 09:42:29 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1313095092-25092-1-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1313095092-25092-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] guest agent: remove g_strcmp0 usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org On 08/11/2011 03:38 PM, Michael Roth wrote: > g_strcmp0 isn't in all version of glib 2.0, so don't use it to avoid > build breakage on older distros. > > Signed-off-by: Michael Roth Applied. Thanks. Regards, Anthony Liguori > --- > qemu-ga.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-ga.c b/qemu-ga.c > index 869ee37..e6ccc21 100644 > --- a/qemu-ga.c > +++ b/qemu-ga.c > @@ -146,7 +146,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level, > } > > level&= G_LOG_LEVEL_MASK; > - if (g_strcmp0(domain, "syslog") == 0) { > + if (domain&& strcmp(domain, "syslog") == 0) { > syslog(LOG_INFO, "%s: %s", level_str, msg); > } else if (level& s->log_level) { > g_get_current_time(&time);