From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kwolf@redhat.com, libvir-list@redhat.com, aliguori@us.ibm.com,
eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] Add support for fd: protocol
Date: Mon, 22 Aug 2011 12:06:54 -0400 [thread overview]
Message-ID: <4E527E9E.5080106@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110822153820.GA4774@lst.de>
On 08/22/2011 11:38 AM, Christoph Hellwig wrote:
> I'm still totally against this. FD passing is a nice feature for sandboxing,
> but the passing should be between closely cooperating programs. We'll
> need a tool shipped from the qemu source tree to open and set up the
> FDs, and not someone external. With that setup in place we can use
> a protocol similar to the various OpenBSD privilegue separated deaemons
> to also allow reopening / snapshots / etc.
>
> Opening fds in libvirt and passing them into qemu is exactly the wrong way,
> and just cements the current horrors where libvirt duplicates parsing
> of image format headers.
>
This is following suit with exiting support that passes an fd for a TAP
interface. Libvirt already passes a file descriptor to Qemu via '-net
tap,fd='. Are you against that as well?
Regards,
Corey
next prev parent reply other threads:[~2011-08-22 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 14:50 [Qemu-devel] [PATCH v4] Add support for fd: protocol Corey Bryant
2011-08-22 15:38 ` Christoph Hellwig
2011-08-22 16:06 ` Corey Bryant [this message]
2011-08-22 16:24 ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2011-08-22 16:29 ` Anthony Liguori
2011-08-22 16:50 ` Daniel P. Berrange
2011-08-22 17:25 ` Anthony Liguori
2011-08-22 17:42 ` Corey Bryant
2011-08-22 18:39 ` Blue Swirl
2011-08-23 15:13 ` Corey Bryant
2011-08-23 15:26 ` Daniel P. Berrange
2011-08-23 15:50 ` Kevin Wolf
2011-08-23 15:51 ` Daniel P. Berrange
2011-08-23 16:04 ` Daniel P. Berrange
2011-08-23 16:14 ` Corey Bryant
2011-08-22 18:22 ` Daniel P. Berrange
2011-08-22 18:54 ` Blue Swirl
2011-08-22 19:25 ` Anthony Liguori
2011-08-23 14:26 ` Corey Bryant
2011-08-23 14:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E527E9E.5080106@linux.vnet.ibm.com \
--to=coreyb@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).