From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvX2l-0005sr-5A for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:08:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvX2j-0005YF-TY for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:08:07 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:44362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvX2j-0005Xx-MT for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:08:05 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7MFm4nd031159 for ; Mon, 22 Aug 2011 09:48:04 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7MG7lHM100686 for ; Mon, 22 Aug 2011 10:07:49 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7MG7grw013024 for ; Mon, 22 Aug 2011 10:07:43 -0600 Message-ID: <4E527E9E.5080106@linux.vnet.ibm.com> Date: Mon, 22 Aug 2011 12:06:54 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1314024650-28510-1-git-send-email-coreyb@linux.vnet.ibm.com> <20110822153820.GA4774@lst.de> In-Reply-To: <20110822153820.GA4774@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] Add support for fd: protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kwolf@redhat.com, libvir-list@redhat.com, aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org On 08/22/2011 11:38 AM, Christoph Hellwig wrote: > I'm still totally against this. FD passing is a nice feature for sandboxing, > but the passing should be between closely cooperating programs. We'll > need a tool shipped from the qemu source tree to open and set up the > FDs, and not someone external. With that setup in place we can use > a protocol similar to the various OpenBSD privilegue separated deaemons > to also allow reopening / snapshots / etc. > > Opening fds in libvirt and passing them into qemu is exactly the wrong way, > and just cements the current horrors where libvirt duplicates parsing > of image format headers. > This is following suit with exiting support that passes an fd for a TAP interface. Libvirt already passes a file descriptor to Qemu via '-net tap,fd='. Are you against that as well? Regards, Corey