From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvYJ8-0007zD-I9 for qemu-devel@nongnu.org; Mon, 22 Aug 2011 13:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvYJ7-00078J-Gz for qemu-devel@nongnu.org; Mon, 22 Aug 2011 13:29:06 -0400 Received: from goliath.siemens.de ([192.35.17.28]:22542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvYJ7-00078D-8T for qemu-devel@nongnu.org; Mon, 22 Aug 2011 13:29:05 -0400 Message-ID: <4E5291DF.1070603@siemens.com> Date: Mon, 22 Aug 2011 19:29:03 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1313294689-21572-1-git-send-email-avi@redhat.com> In-Reply-To: <1313294689-21572-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kevin Wolf , qemu-devel@nongnu.org, kvm@vger.kernel.org On 2011-08-14 06:04, Avi Kivity wrote: > In certain circumstances, posix-aio-compat can incur a lot of latency: > - threads are created by vcpu threads, so if vcpu affinity is set, > aio threads inherit vcpu affinity. This can cause many aio threads > to compete for one cpu. > - we can create up to max_threads (64) aio threads in one go; since a > pthread_create can take around 30=CE=BCs, we have up to 2ms of cpu t= ime > under a global lock. >=20 > Fix by: > - moving thread creation to the main thread, so we inherit the main > thread's affinity instead of the vcpu thread's affinity. > - if a thread is currently being created, and we need to create yet > another thread, let thread being born create the new thread, reducin= g > the amount of time we spend under the main thread. > - drop the local lock while creating a thread (we may still hold the > global mutex, though) >=20 > Note this doesn't eliminate latency completely; scheduler artifacts or > lack of host cpu resources can still cause it. We may want pre-allocat= ed > threads when this cannot be tolerated. >=20 > Thanks to Uli Obergfell of Red Hat for his excellent analysis and sugge= stions. At this chance: What is the state of getting rid of the remaining delta between upstream's version and qemu-kvm? Jan --=20 Siemens AG Corporate Technology CT T DE IT 1 Corporate Competence Center Embedded Linux Otto-Hahn-Ring 6 81739 Muenchen Tel.: +49 (89) 636-40042 Fax: +49 (89) 636-45450 mailto:jan.kiszka@siemens.com Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard Cromme; Managing Board: Peter Loescher, Chairman, President and Chief Executive Officer; Roland Busch, Brigitte Ederer, Klaus Helmrich, Joe Kaeser, Barbara Kux, Hermann Requardt, Siegfried Russwurm, Peter Y. Solmssen, Michael Suess; Registered offices: Berlin and Munich, Germany; Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. DE 23691322