From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qw9f6-00037R-Ot
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:22:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qw9f4-0002iZ-TZ
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:22:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60064)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qw9f4-0002iV-Jw
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:22:14 -0400
Message-ID: <4E54C2C2.3030603@redhat.com>
Date: Wed, 24 Aug 2011 12:22:10 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1314021534-3212-1-git-send-email-avi@redhat.com>
	<alpine.LFD.2.02.1108221603050.24813@bbs.intern>
In-Reply-To: <alpine.LFD.2.02.1108221603050.24813@bbs.intern>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O
	accessors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote:
> Hello Avi,
>
> Thnx, fixed: OK, maybe some credits :-)
>
> Acked-by: Gerhard Wiesinger <lists@wiesinger.com>
>
> This pattern is still present at (maybe some further problems!!!) and 
> I guess it has to be fixed, too:
>
> grep -ir 'ops, s, "' .
> ./hw/rtl8139.c:    memory_region_init_io(&s->bar_io, &rtl8139_io_ops, 
> s, "rtl8139", 0x100);
> ./hw/rtl8139.c:    memory_region_init_io(&s->bar_mem, 
> &rtl8139_mmio_ops, s, "rtl8139", 0x100);

Usually, when you have

   memory_region_init_io(&s->something, ..., s, ...)

it means everything is fine.  Lance/pcnet is special in this regard.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.