From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwAvD-0007g2-LY for qemu-devel@nongnu.org; Wed, 24 Aug 2011 06:43:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwAvC-0006Gd-Kc for qemu-devel@nongnu.org; Wed, 24 Aug 2011 06:42:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwAvC-0006GU-7H for qemu-devel@nongnu.org; Wed, 24 Aug 2011 06:42:58 -0400 Message-ID: <4E54D5A4.1030804@redhat.com> Date: Wed, 24 Aug 2011 13:42:44 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314180683-8227-1-git-send-email-avi@redhat.com> <1314180683-8227-2-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/24] arm_sysctl: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On 08/24/2011 01:23 PM, Peter Maydell wrote: > On 24 August 2011 11:11, Avi Kivity wrote: > > Signed-off-by: Avi Kivity > > --- > > hw/arm_sysctl.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c > > index 17cf6f7..5b845a2 100644 > > --- a/hw/arm_sysctl.c > > +++ b/hw/arm_sysctl.c > > @@ -19,6 +19,7 @@ typedef struct { > > SysBusDevice busdev; > > MemoryRegion iomem; > > qemu_irq pl110_mux_ctrl; > > + MemoryRegion iomem; > > > > uint32_t sys_id; > > uint32_t leds; > > Er, looks like you forgot to squish Richard's compile fix patch? > Not applied yet; will fix. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.