From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwBoC-0001qb-8R for qemu-devel@nongnu.org; Wed, 24 Aug 2011 07:39:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwBoA-00042C-Gs for qemu-devel@nongnu.org; Wed, 24 Aug 2011 07:39:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwBoA-000422-6w for qemu-devel@nongnu.org; Wed, 24 Aug 2011 07:39:46 -0400 Message-ID: <4E54E2F8.2040007@redhat.com> Date: Wed, 24 Aug 2011 14:39:36 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314180683-8227-1-git-send-email-avi@redhat.com> <1314180683-8227-22-git-send-email-avi@redhat.com> <4E54D6CF.2060908@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On 08/24/2011 02:38 PM, Peter Maydell wrote: > On 24 August 2011 11:47, Avi Kivity wrote: > > On 08/24/2011 01:35 PM, Peter Maydell wrote: > >> > >> On 24 August 2011 11:11, Avi Kivity wrote: > >> > diff --git a/hw/mcf5208.c b/hw/mcf5208.c > >> > index f4d4fbd..73c6961 100644 > >> > --- a/hw/mcf5208.c > >> > +++ b/hw/mcf5208.c > >> > @@ -5,6 +5,7 @@ > >> > * > >> > * This code is licensed under the GPL > >> > */ > >> > +#include > >> > #include "hw.h" > >> > #include "mcf.h" > >> > #include "qemu-timer.h" > >> > >> You shouldn't need to include glib.h here, I think? hw.h includes > >> qemu-common.h > >> which includes glib.h. > >> > > > > My preference is not to depend on indirect includes; but I can remove this > > include if it's disliked by many. > > qemu-common.h says > /* we put basic includes here to avoid repeating them in device drivers */ > > so direct includes of system headers in hw/ files is going against > current practice. I don't feel strongly either way on the question > of direct vs indirect, but we should be consistent, and the choice > we've made is "rely on qemu-common.h". > Okay, I'll drop the include (here and elsewhere). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.