From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwCzj-0000Pz-07
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:55:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwCzh-0005Kh-IZ
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:55:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwCzh-0005KX-AV
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:55:45 -0400
Message-ID: <4E54F4CE.3030309@redhat.com>
Date: Wed, 24 Aug 2011 15:55:42 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1312831898-18702-1-git-send-email-aliguori@us.ibm.com>
	<4E54C8C3.4050609@redhat.com> <4E54F0BA.60106@us.ibm.com>
In-Reply-To: <4E54F0BA.60106@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>, qemu-devel@nongnu.org

On 08/24/2011 03:38 PM, Anthony Liguori wrote:
>>
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index 1c9d89a..4b07b35 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -549,8 +549,7 @@ static void bochs_bios_write(void *opaque,
>>> uint32_t addr, uint32_t val)
>>> /* LGPL'ed VGA BIOS messages */
>>> case 0x501:
>>> case 0x502:
>>> - fprintf(stderr, "VGA BIOS panic, line %d\n", val);
>>> - exit(1);
>>> + exit((val<< 1) | 1);
>>
>> This code (before the patch) circumvents -no-shutdown.
>
>
> Indeed.  I believe that's a feature though?

Depends on what the user of -no-shutdown expects.

>
>>
>> Shifting val left is surprising. What's wrong with even exit codes?
>
> Hrm, the '| 1' is wrong.  My intention was to make the bottom bit of 
> the exit code mean "if set to 0, this is an exit coming from a guest'.

Too subtle, IMO.  I understand that we want to avoid a full qmp parser 
for one-off unit tests, but using bit fields in the exit code?

Perhaps a python script that launches qemu with qmp and -no-shutdown, 
listens for the guest shutdown event, and prints out the result?  That 
can be easily reused in test scripts.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.