From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwD2Y-0002eF-Ma
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:58:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwD2X-000694-Ep
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:58:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QwD2X-00068y-4g
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:58:41 -0400
Message-ID: <4E54F57D.8070809@redhat.com>
Date: Wed, 24 Aug 2011 15:58:37 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1314187627-20975-1-git-send-email-avi@redhat.com>
	<4E54F2A2.6000100@siemens.com>
In-Reply-To: <4E54F2A2.6000100@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vga: squash build error in
	vga_update_memory_access()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org

On 08/24/2011 03:46 PM, Jan Kiszka wrote:
> >  +++ b/hw/vga.c
> >  @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s)
> >               base = 0xb8000;
> >               size = 0x8000;
> >               break;
> >  +        default:
> >  +            abort();
> >           }
> >           region = g_malloc(sizeof(*region));
> >           memory_region_init_alias(region, "vga.chain4",&s->vram, offset, size);
>
> ...or just make the last case default?
>

No reason to make the code unobvious in this path, IMO.  Eventually gcc 
will be able to drop the 4/5 bytes this patch adds to the object code.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.